third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html - Issue 2222163005: Updating media controls to give fullscreen button highest priority

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html

Issue 2222163005: Updating media controls to give fullscreen button highest priority (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Tests that the fullscreen button control is visible last.</title>

	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="media-file.js"></script>

	6 <script src="media-controls.js"></script>

	7 <script src="video-controls-fullscreen.js"></script>
	mlamouri (slow - plz ping) 2016/08/10 15:34:24 Could you move hasFullscreenButton() to media-cont Could you move hasFullscreenButton() to media-controls.js. video-controls-fullscreen.js is meant to be used in a few specific tests. All of which include media-controls.js. kdsilva 2016/08/12 08:59:55 Done. Show quoted text On 2016/08/10 15:34:24, Mounir Lamouri wrote: > Could you move hasFullscreenButton() to media-controls.js. > video-controls-fullscreen.js is meant to be used in a few specific tests. All of > which include media-controls.js. Done.
	8 <video controls></video>

	9 <script>

	10 async_test(function(t) {

	11 var video = document.querySelector("video");

	12 video.src = findMediaFile("video", "content/test");

	13 video.setAttribute("width", "70");

	14 video.addTextTrack("captions");

	15 video.onloadeddata = t.step_func_done(function() {

	16 assert_true(hasFullscreenButton(video));

	17 assert_false(isClosedCaptionsButtonVisible(video));

	18 });

	19 });

	20 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControls.cpp » ('j') | no next file with comments »