Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: masters/master.client.webrtc/master_mac_cfg.py

Issue 2222163004: convert most webrtc builders to remote_run (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « masters/master.client.webrtc/master_linux_cfg.py ('k') | masters/master.client.webrtc/master_win_cfg.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: masters/master.client.webrtc/master_mac_cfg.py
diff --git a/masters/master.client.webrtc/master_mac_cfg.py b/masters/master.client.webrtc/master_mac_cfg.py
index 6fc0d0d383f48e1622494f09ff332be580629ed2..3f589abc289064383f00cf11925e78de42eb029f 100644
--- a/masters/master.client.webrtc/master_mac_cfg.py
+++ b/masters/master.client.webrtc/master_mac_cfg.py
@@ -4,9 +4,20 @@
from buildbot.schedulers.basic import SingleBranchScheduler
-from master.factory import annotator_factory
+from master.factory import remote_run_factory
+
+import master_site_config
+ActiveMaster = master_site_config.WebRTC
+
+
+def m_remote_run(recipe, **kwargs):
+ return remote_run_factory.RemoteRunFactory(
+ active_master=ActiveMaster,
+ repository='https://chromium.googlesource.com/chromium/tools/build.git',
kjellander_chromium 2016/08/09 14:16:21 This URL is duplicated a lot. Is that a good long-
Paweł Hajdan Jr. 2016/08/09 15:04:52 The long term solution is to get rid of buildbot.
+ recipe=recipe,
+ factory_properties={'path_config': 'kitchen'},
+ **kwargs)
-m_annotator = annotator_factory.AnnotatorFactory()
def Update(c):
c['schedulers'].extend([
@@ -95,8 +106,7 @@ def Update(c):
c['builders'].extend([
{
'name': spec['name'],
- 'factory': m_annotator.BaseFactory(spec.get('recipe',
- 'webrtc/standalone')),
+ 'factory': m_remote_run(spec.get('recipe', 'webrtc/standalone')),
'notify_on_missing': True,
'category': spec.get('category', 'compile|testers'),
'slavebuilddir': spec['slavebuilddir'],
« no previous file with comments | « masters/master.client.webrtc/master_linux_cfg.py ('k') | masters/master.client.webrtc/master_win_cfg.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698