Create blurred RRect mask on GPU (rather than uploading it)

Create blurred RRect mask on GPU (rather than uploading it)

This CL doesn't try to resolve any of the larger issues. It just moves the computation of the blurred RRect to the gpu and sets up to start using vertex attributes for a nine patch draw (i.e., returning the texture coordinates)

All blurred rrects using the "analytic" path will change slightly with this CL.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222083004

Committed: https://skia.googlesource.com/skia/+/75ccdc77a70ec2083141bf9ba98eb2f01ece2479
Committed: https://skia.googlesource.com/skia/+/94b5c5a41160e0f55e267fc3d830df65736fac50
Committed: https://skia.googlesource.com/skia/+/f5a83e818483ef910ffd107df8f98b5ee24671f5

[robertphillips, 2016-08-09 12:47:22]

Description was changed from

==========
Create blurred RRect mask on GPU (rather than uploading it)
==========

to

==========
Create blurred RRect mask on GPU (rather than uploading it)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222083004
==========

[robertphillips, 2016-08-09 18:51:14]

Description was changed from

==========
Create blurred RRect mask on GPU (rather than uploading it)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222083004
==========

to

==========
Create blurred RRect mask on GPU (rather than uploading it)

This CL doesn't try to resolve any of the larger issues. It just moves the
computation of the blurred RRect to the gpu and sets up to start using vertex
attributes for a nine patch draw (i.e., returning the texture coordinates)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222083004
==========

[robertphillips, 2016-08-09 18:51:14]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2016-08-09 18:51:43]

Description was changed from

==========
Create blurred RRect mask on GPU (rather than uploading it)

This CL doesn't try to resolve any of the larger issues. It just moves the
computation of the blurred RRect to the gpu and sets up to start using vertex
attributes for a nine patch draw (i.e., returning the texture coordinates)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222083004
==========

to

==========
Create blurred RRect mask on GPU (rather than uploading it)

This CL doesn't try to resolve any of the larger issues. It just moves the
computation of the blurred RRect to the gpu and sets up to start using vertex
attributes for a nine patch draw (i.e., returning the texture coordinates)

All blurred rrects using the "analytic" path will change slightly with this CL.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222083004
==========

[robertphillips, 2016-08-09 19:00:24]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 19:00:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 19:35:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 19:35:44]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-08-09 20:32:39]

lgtm

[robertphillips, 2016-08-10 12:02:06]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-08-10 12:02:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 12:33:15]

Description was changed from

==========
Create blurred RRect mask on GPU (rather than uploading it)

This CL doesn't try to resolve any of the larger issues. It just moves the
computation of the blurred RRect to the gpu and sets up to start using vertex
attributes for a nine patch draw (i.e., returning the texture coordinates)

All blurred rrects using the "analytic" path will change slightly with this CL.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222083004
==========

to

==========
Create blurred RRect mask on GPU (rather than uploading it)

This CL doesn't try to resolve any of the larger issues. It just moves the
computation of the blurred RRect to the gpu and sets up to start using vertex
attributes for a nine patch draw (i.e., returning the texture coordinates)

All blurred rrects using the "analytic" path will change slightly with this CL.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222083004

Committed:
https://skia.googlesource.com/skia/+/75ccdc77a70ec2083141bf9ba98eb2f01ece2479
==========

[commit-bot: I haz the power, 2016-08-10 12:33:17]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/75ccdc77a70ec2083141bf9ba98eb2f01ece2479

[robertphillips, 2016-08-10 13:15:20]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2236493002/ by robertphillips@google.com.

The reason for reverting is: Erg - dumb bug.

[robertphillips, 2016-08-10 13:31:50]

Description was changed from

==========
Create blurred RRect mask on GPU (rather than uploading it)

This CL doesn't try to resolve any of the larger issues. It just moves the
computation of the blurred RRect to the gpu and sets up to start using vertex
attributes for a nine patch draw (i.e., returning the texture coordinates)

All blurred rrects using the "analytic" path will change slightly with this CL.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222083004

Committed:
https://skia.googlesource.com/skia/+/75ccdc77a70ec2083141bf9ba98eb2f01ece2479
==========

to

==========
Create blurred RRect mask on GPU (rather than uploading it)

This CL doesn't try to resolve any of the larger issues. It just moves the
computation of the blurred RRect to the gpu and sets up to start using vertex
attributes for a nine patch draw (i.e., returning the texture coordinates)

All blurred rrects using the "analytic" path will change slightly with this CL.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222083004

Committed:
https://skia.googlesource.com/skia/+/75ccdc77a70ec2083141bf9ba98eb2f01ece2479
==========

[robertphillips, 2016-08-10 13:47:24]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-08-10 13:47:25]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2222083004/#ps80001
(title: "Add clear")

[commit-bot: I haz the power, 2016-08-10 13:47:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 14:14:58]

Description was changed from

==========
Create blurred RRect mask on GPU (rather than uploading it)

This CL doesn't try to resolve any of the larger issues. It just moves the
computation of the blurred RRect to the gpu and sets up to start using vertex
attributes for a nine patch draw (i.e., returning the texture coordinates)

All blurred rrects using the "analytic" path will change slightly with this CL.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222083004

Committed:
https://skia.googlesource.com/skia/+/75ccdc77a70ec2083141bf9ba98eb2f01ece2479
==========

to

==========
Create blurred RRect mask on GPU (rather than uploading it)

This CL doesn't try to resolve any of the larger issues. It just moves the
computation of the blurred RRect to the gpu and sets up to start using vertex
attributes for a nine patch draw (i.e., returning the texture coordinates)

All blurred rrects using the "analytic" path will change slightly with this CL.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222083004

Committed:
https://skia.googlesource.com/skia/+/75ccdc77a70ec2083141bf9ba98eb2f01ece2479
Committed:
https://skia.googlesource.com/skia/+/94b5c5a41160e0f55e267fc3d830df65736fac50
==========

[commit-bot: I haz the power, 2016-08-10 14:14:59]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/94b5c5a41160e0f55e267fc3d830df65736fac50

[robertphillips, 2016-08-10 15:40:24]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2232953002/ by robertphillips@google.com.

The reason for reverting is: No NoGPU bot on commit queue ?.

[robertphillips, 2016-08-10 15:51:41]

Description was changed from

==========
Create blurred RRect mask on GPU (rather than uploading it)

This CL doesn't try to resolve any of the larger issues. It just moves the
computation of the blurred RRect to the gpu and sets up to start using vertex
attributes for a nine patch draw (i.e., returning the texture coordinates)

All blurred rrects using the "analytic" path will change slightly with this CL.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222083004

Committed:
https://skia.googlesource.com/skia/+/75ccdc77a70ec2083141bf9ba98eb2f01ece2479
Committed:
https://skia.googlesource.com/skia/+/94b5c5a41160e0f55e267fc3d830df65736fac50
==========

to

==========
Create blurred RRect mask on GPU (rather than uploading it)

This CL doesn't try to resolve any of the larger issues. It just moves the
computation of the blurred RRect to the gpu and sets up to start using vertex
attributes for a nine patch draw (i.e., returning the texture coordinates)

All blurred rrects using the "analytic" path will change slightly with this CL.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222083004

Committed:
https://skia.googlesource.com/skia/+/75ccdc77a70ec2083141bf9ba98eb2f01ece2479
Committed:
https://skia.googlesource.com/skia/+/94b5c5a41160e0f55e267fc3d830df65736fac50
==========

[robertphillips, 2016-08-10 16:11:31]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 16:11:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-08-10 16:53:35]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 16:53:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 17:21:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 17:21:08]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-08-10 17:23:16]

Third times a charm

[bsalomon, 2016-08-10 17:43:19]

I think the clear takes a GrColor not a SkColor. Otherwise lgtm

https://codereview.chromium.org/2222083004/diff/100001/src/effects/SkBlurMask...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/2222083004/diff/100001/src/effects/SkBlurMask...
src/effects/SkBlurMaskFilter.cpp:1024: dc->clear(nullptr, SK_ColorTRANSPARENT,
true);
I think this takes a GrColor

[robertphillips, 2016-08-10 18:31:45]

https://codereview.chromium.org/2222083004/diff/100001/src/effects/SkBlurMask...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/2222083004/diff/100001/src/effects/SkBlurMask...
src/effects/SkBlurMaskFilter.cpp:1024: dc->clear(nullptr, SK_ColorTRANSPARENT,
true);
On 2016/08/10 17:43:19, bsalomon wrote:
> I think this takes a GrColor

Done.

[robertphillips, 2016-08-10 18:31:52]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-08-10 18:31:52]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2222083004/#ps140001
(title: "SkColor -> GrColor")

[commit-bot: I haz the power, 2016-08-10 18:31:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 19:00:11]

Description was changed from

==========
Create blurred RRect mask on GPU (rather than uploading it)

This CL doesn't try to resolve any of the larger issues. It just moves the
computation of the blurred RRect to the gpu and sets up to start using vertex
attributes for a nine patch draw (i.e., returning the texture coordinates)

All blurred rrects using the "analytic" path will change slightly with this CL.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222083004

Committed:
https://skia.googlesource.com/skia/+/75ccdc77a70ec2083141bf9ba98eb2f01ece2479
Committed:
https://skia.googlesource.com/skia/+/94b5c5a41160e0f55e267fc3d830df65736fac50
==========

to

==========
Create blurred RRect mask on GPU (rather than uploading it)

This CL doesn't try to resolve any of the larger issues. It just moves the
computation of the blurred RRect to the gpu and sets up to start using vertex
attributes for a nine patch draw (i.e., returning the texture coordinates)

All blurred rrects using the "analytic" path will change slightly with this CL.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222083004

Committed:
https://skia.googlesource.com/skia/+/75ccdc77a70ec2083141bf9ba98eb2f01ece2479
Committed:
https://skia.googlesource.com/skia/+/94b5c5a41160e0f55e267fc3d830df65736fac50
Committed:
https://skia.googlesource.com/skia/+/f5a83e818483ef910ffd107df8f98b5ee24671f5
==========

[commit-bot: I haz the power, 2016-08-10 19:00:13]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/f5a83e818483ef910ffd107df8f98b5ee24671f5