Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2222043002: Rename CJS_Timer to GlobalTimer and make private to app.cpp (Closed)

Created:
4 years, 4 months ago by Tom Sepez
Modified:
4 years, 4 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename CJS_Timer to GlobalTimer and make private to app.cpp The CJS_Timer is fairly far removed from JS itself, the wrapper objects are CJS_TimerObj and TimerObj. Make it sound less like them. Having moved the code to app.cpp, the GlobalTimer can now refer directly to the app, rather than its superclass of CJS_EmbedObj. Hence we can pull some app-only timer related methods out of the superclass. Committed: https://pdfium.googlesource.com/pdfium/+/e3ff76b11ac6fcd0d0196ef83946d2321ab8e9bf

Patch Set 1 : Sed only #

Patch Set 2 : Move code into app.cpp #

Patch Set 3 : De-virtualize #

Patch Set 4 : Fix comment in app.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -140 lines) Patch
M fpdfsdk/javascript/JS_Object.h View 1 2 3 chunks +0 lines, -43 lines 0 comments Download
M fpdfsdk/javascript/JS_Object.cpp View 1 1 chunk +0 lines, -82 lines 0 comments Download
M fpdfsdk/javascript/app.h View 1 2 3 2 chunks +7 lines, -6 lines 0 comments Download
M fpdfsdk/javascript/app.cpp View 1 2 6 chunks +131 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Tom Sepez
Dan, more cleanup.
4 years, 4 months ago (2016-08-08 18:33:27 UTC) #6
dsinclair
lgtm
4 years, 4 months ago (2016-08-08 18:41:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222043002/60001
4 years, 4 months ago (2016-08-08 18:41:12 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 18:58:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/e3ff76b11ac6fcd0d0196ef83946d2321ab8...

Powered by Google App Engine
This is Rietveld 408576698