Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: fpdfsdk/javascript/app.h

Issue 2222043002: Rename CJS_Timer to GlobalTimer and make private to app.cpp (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Fix comment in app.h Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/javascript/JS_Object.cpp ('k') | fpdfsdk/javascript/app.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/javascript/app.h
diff --git a/fpdfsdk/javascript/app.h b/fpdfsdk/javascript/app.h
index bb083cedb449dcd8004c439cac95672e7ff006cc..52dfd2f9ca25ff90bf18cdb825817631784f9d35 100644
--- a/fpdfsdk/javascript/app.h
+++ b/fpdfsdk/javascript/app.h
@@ -13,18 +13,18 @@
#include "fpdfsdk/javascript/JS_Define.h"
class CJS_Runtime;
-class CJS_Timer;
+class GlobalTimer;
class TimerObj : public CJS_EmbedObj {
public:
TimerObj(CJS_Object* pJSObject);
~TimerObj() override;
- void SetTimer(CJS_Timer* pTimer);
+ void SetTimer(GlobalTimer* pTimer);
int GetTimerID() const { return m_nTimerID; }
private:
- int m_nTimerID; // Weak reference to timer through global map.
+ int m_nTimerID; // Weak reference to GlobalTimer through global map.
};
class CJS_TimerObj : public CJS_Object {
@@ -152,19 +152,20 @@ class app : public CJS_EmbedObj {
CJS_Value& vRet,
CFX_WideString& sError);
+ void TimerProc(GlobalTimer* pTimer);
+ void CancelProc(GlobalTimer* pTimer);
+
static CFX_WideString SysPathToPDFPath(const CFX_WideString& sOldPath);
private:
// CJS_EmbedObj
- void TimerProc(CJS_Timer* pTimer) override;
- void CancelProc(CJS_Timer* pTimer) override;
void RunJsScript(CJS_Runtime* pRuntime, const CFX_WideString& wsScript);
void ClearTimerCommon(const CJS_Value& param);
bool m_bCalculate;
bool m_bRuntimeHighLight;
- std::vector<std::unique_ptr<CJS_Timer>> m_Timers;
+ std::vector<std::unique_ptr<GlobalTimer>> m_Timers;
};
class CJS_App : public CJS_Object {
« no previous file with comments | « fpdfsdk/javascript/JS_Object.cpp ('k') | fpdfsdk/javascript/app.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698