Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 2221933002: Fix alpha bug in SkColorXform (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : R to c #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/core/SkColorSpaceXformOpts.h View 1 2 chunks +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (10 generated)
msarett
4 years, 4 months ago (2016-08-08 14:27:50 UTC) #3
mtklein
https://codereview.chromium.org/2221933002/diff/1/src/core/SkColorSpaceXformOpts.h File src/core/SkColorSpaceXformOpts.h (right): https://codereview.chromium.org/2221933002/diff/1/src/core/SkColorSpaceXformOpts.h#newcode372 src/core/SkColorSpaceXformOpts.h:372: src += 4; Might be clearer to move src+=4, ...
4 years, 4 months ago (2016-08-08 14:29:23 UTC) #6
msarett
https://codereview.chromium.org/2221933002/diff/1/src/core/SkColorSpaceXformOpts.h File src/core/SkColorSpaceXformOpts.h (right): https://codereview.chromium.org/2221933002/diff/1/src/core/SkColorSpaceXformOpts.h#newcode372 src/core/SkColorSpaceXformOpts.h:372: src += 4; On 2016/08/08 14:29:23, mtklein wrote: > ...
4 years, 4 months ago (2016-08-08 14:31:08 UTC) #7
mtklein
lgtm
4 years, 4 months ago (2016-08-08 14:32:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221933002/20001
4 years, 4 months ago (2016-08-08 15:12:17 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 15:13:12 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b9a10d8c75bfff7bfe9cbb4f74c71ac3494d418b

Powered by Google App Engine
This is Rietveld 408576698