ios: fix path to the test app

ios: fix path to the test app

BUG=584079, 593999
Committed: https://chromium.googlesource.com/chromium/tools/build/+/15eadb86674b47f07b21648deb3302b4c9891357

[Paweł Hajdan Jr., 2016-08-08 14:21:53]

phajdan.jr@chromium.org changed reviewers:
+ emso@chromium.org, sergiyb@chromium.org, tandrii@chromium.org

[Paweł Hajdan Jr., 2016-08-08 14:21:53]

Example failure:

https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/9035/st...
:

@@@STEP_TEXT@AppNotFoundError: App does not exist:
/b/rr/tmpOiDKwT/w/src/out/Debug-iphonesimulator/ios_web_shell_test_host.app.@@@

[Sergiy Byelozyorov, 2016-08-08 14:32:49]

lgtm

https://codereview.chromium.org/2221923002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/ios/api.py (right):

https://codereview.chromium.org/2221923002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/ios/api.py:393: '--app', self.m.path.join(
nit: please fix whitespace before '--app'

[Paweł Hajdan Jr., 2016-08-08 14:40:30]

https://codereview.chromium.org/2221923002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/ios/api.py (right):

https://codereview.chromium.org/2221923002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/ios/api.py:393: '--app', self.m.path.join(
On 2016/08/08 at 14:32:49, Sergiy Byelozyorov wrote:
> nit: please fix whitespace before '--app'

It's already aligned. Discussed over IM.

[Paweł Hajdan Jr., 2016-08-08 14:40:32]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2016-08-08 14:40:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sergiy Byelozyorov, 2016-08-08 14:40:47]

https://codereview.chromium.org/2221923002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/ios/api.py (right):

https://codereview.chromium.org/2221923002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/ios/api.py:393: '--app', self.m.path.join(
On 2016/08/08 14:32:49, Sergiy Byelozyorov wrote:
> nit: please fix whitespace before '--app'

my bad... this is actually correct spacing, please then move self.m.path.join
onto the next line, e.g.

  self.package_repo_resource(
    'scripts', 'slave', 'ios', 'run.py'),
  '--app',
  self.m.path['slave_build'].join(

[Sergiy Byelozyorov, 2016-08-08 14:41:44]

lgtm

https://codereview.chromium.org/2221923002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/ios/api.py (right):

https://codereview.chromium.org/2221923002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/ios/api.py:393: '--app', self.m.path.join(
On 2016/08/08 14:40:47, Sergiy Byelozyorov wrote:
> On 2016/08/08 14:32:49, Sergiy Byelozyorov wrote:
> > nit: please fix whitespace before '--app'
> 
> my bad... this is actually correct spacing, please then move self.m.path.join
> onto the next line, e.g.
> 
>   self.package_repo_resource(
>     'scripts', 'slave', 'ios', 'run.py'),
>   '--app',
>   self.m.path['slave_build'].join(

this is just imho, so up to you

[commit-bot: I haz the power, 2016-08-08 14:44:21]

Description was changed from

==========
ios: fix path to the test app

BUG=584079, 593999
==========

to

==========
ios: fix path to the test app

BUG=584079, 593999

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/15eadb86674b47f07b21...
==========

[commit-bot: I haz the power, 2016-08-08 14:44:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/15eadb86674b47f07b21...

[smut, 2016-08-10 23:53:39]

smut@google.com changed reviewers:
+ smut@google.com

[smut, 2016-08-10 23:53:39]

https://codereview.chromium.org/2221923002/diff/1/scripts/slave/recipes/ios/t...
File scripts/slave/recipes/ios/try.expected/swarming.json (right):

https://codereview.chromium.org/2221923002/diff/1/scripts/slave/recipes/ios/t...
scripts/slave/recipes/ios/try.expected/swarming.json:500:
"@@@STEP_LOG_LINE@0.isolate.gen.json@   
\"[BUILDER_CACHE]/ios_simulator_swarming/src/out/Debug-iphonesimulator/fake
test.app\", @@@",
This is wrong. This command needs to use relative paths because the absolute
paths on the builder do not exist on Swarming.