ios: fix path to the test app

scripts/slave/recipe_modules/ios/api.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import copy
 
 from recipe_engine import recipe_api
 
 
 class iOSApi(recipe_api.RecipeApi):
@@ skipping 372 matching lines @@
       *args: Any additional arguments to pass to the test harness.
     """
     assert self.__config is not None
     test_failures = []
     infrastructure_failures = []
 
     for test in self.__config['tests']:
       cmd = [
         self.package_repo_resource(
           'scripts', 'slave', 'ios', 'run.py'),
-        '--app', self.m.path['slave_build'].join(
+        '--app', self.m.path.join(

[Sergiy Byelozyorov, 2016/08/08 14:32:49]

nit: please fix whitespace before '--app'

[Paweł Hajdan Jr., 2016/08/08 14:40:30]

It's already aligned. Discussed over IM.

[Sergiy Byelozyorov, 2016/08/08 14:40:47]

my bad... this is actually correct spacing, please then move self.m.path.join
onto the next line, e.g.

  self.package_repo_resource(
    'scripts', 'slave', 'ios', 'run.py'),
  '--app',
  self.m.path['slave_build'].join(

[Sergiy Byelozyorov, 2016/08/08 14:41:44]

this is just imho, so up to you

           self.most_recent_app_dir,
           '%s.app' % test['app'],
         ),
         '--json_file', self.m.json.output(),
       ]
       if test.get('xctest'):
         cmd.extend([
           '--test-host', test['app'],
           '--dummyproj', self.package_repo_resource(
             'scripts', 'slave', 'ios', 'TestProject', 'TestProject.xcodeproj'),
@@ skipping 313 matching lines @@
     build_dir = {
       'xcodebuild': 'xcodebuild',
       'ninja': 'out',
     }[self.compiler]
 
     platform = {
       'device': 'iphoneos',
       'simulator': 'iphonesimulator',
     }[self.platform]
 
-    return self.m.path.join(
-      'src',
+    return self.m.path['checkout'].join(
       build_dir,
       '%s-%s' % (self.configuration, platform),
     )
 
   @property
   def most_recent_iossim(self):
     """Returns the path to the most recently compiled iossim."""
     build_dir = {
       'xcodebuild': self.m.path.join('xcodebuild', 'ninja-iossim'),
       'ninja': 'out',
@@ skipping 24 matching lines @@
         self.configuration,
         'iossim',
       ),
       'ninja': self.m.path.join(
         'src',
          build_dir,
          '%s-%s' % (self.configuration, platform),
          'iossim',
       ),
     }[self.compiler]