components/crash/content/app/crash_reporter_client.h - Issue 2221833005: Adding support for sampling crashes in Chrome on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/content/app/crash_reporter_client.h

Issue 2221833005: Adding support for sampling crashes in Chrome on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding support for sampling crashes in Chrome on Windows. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/install_static/install_util.cc ('K') | « chrome/install_static/install_util.cc ('k') | components/crash/content/app/crash_reporter_client.cc » ('j') | components/crash/content/app/crash_reporter_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/crash/content/app/crash_reporter_client.h

diff --git a/components/crash/content/app/crash_reporter_client.h b/components/crash/content/app/crash_reporter_client.h

index 157ba53e1361493bcc4632caafa01b0052d8c4ea..a6b8cb1d63e13774fb545604d13f9d7792d7db8c 100644

--- a/components/crash/content/app/crash_reporter_client.h

+++ b/components/crash/content/app/crash_reporter_client.h

@@ -138,6 +138,10 @@ class CrashReporterClient {

// Returns true if the user has given consent to collect stats.

virtual bool GetCollectStatsConsent();

+ // Returns false if the client is affected by sampling, and shouldn't report

+ // crashes. Otherwise, returns true.

Alexei Svitkine (slow) 2016/08/10 21:49:33 Please expand comment to mention interaction with

jwd 2016/08/11 21:41:03 Done.

+ virtual bool GetCollectStatsInSample();

#if defined(OS_WIN) || defined(OS_MACOSX)

// Returns true if crash reporting is enforced via management policies. In

// that case, |breakpad_enabled| is set to the value enforced by policies.