components/crash/content/app/crash_reporter_client.cc - Issue 2221833005: Adding support for sampling crashes in Chrome on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/content/app/crash_reporter_client.cc

Issue 2221833005: Adding support for sampling crashes in Chrome on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding support for sampling crashes in Chrome on Windows. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/crash/content/app/crash_reporter_client.h ('K') | « components/crash/content/app/crash_reporter_client.h ('k') | components/crash/content/app/crashpad.cc » ('j') | components/crash/content/app/crashpad.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/crash/content/app/crash_reporter_client.cc

diff --git a/components/crash/content/app/crash_reporter_client.cc b/components/crash/content/app/crash_reporter_client.cc

index 22b95712995b6f31b1d2b132b3370317f5173f15..a94354d65a780fcc4e0ed86eba100919feea0347 100644

--- a/components/crash/content/app/crash_reporter_client.cc

+++ b/components/crash/content/app/crash_reporter_client.cc

@@ -122,6 +122,10 @@ bool CrashReporterClient::GetCollectStatsConsent() {

return false;

}

+bool CrashReporterClient::GetCollectStatsInSample() {

+ return true;

Alexei Svitkine (slow) 2016/08/10 21:49:33 Maybe add a comment about why true as default valu

jwd 2016/08/11 21:41:03 Done.

#if defined(OS_WIN) || defined(OS_MACOSX)

bool CrashReporterClient::ReportingIsEnforcedByPolicy(bool* breakpad_enabled) {

return false;