Adding support for sampling crashes in Chrome on Windows.

chrome/install_static/install_util.h

Index: chrome/install_static/install_util.h
diff --git a/chrome/install_static/install_util.h b/chrome/install_static/install_util.h
index be2a99d4751a49c8509b9b5559afe9b048bcb455..a406699c15ab4fcb78056abda356c50a7e67408b 100644
--- a/chrome/install_static/install_util.h
+++ b/chrome/install_static/install_util.h
@@ -41,6 +41,9 @@ extern const wchar_t kAppGuidCanary[];
 extern const wchar_t kAppGuidGoogleChrome[];
 extern const wchar_t kAppGuidGoogleBinaries[];
 
+extern const wchar_t kChromeMetrics[];
+extern const wchar_t kChromeStatsSampleKey[];

[Alexei Svitkine (slow), 2016/08/10 21:49:33]

Are you missing the bit that sets these?

[jwd, 2016/08/11 21:41:03]

Moved setting from chrome_metrics_services_client to here.

+
 // TODO(ananta)
 // https://crbug.com/604923
 // Unify these constants with env_vars.h.
@@ -78,6 +81,11 @@ bool GetCollectStatsConsent();
 // Only used by tests.
 bool GetCollectStatsConsentForTesting(const std::wstring& exe_path);
 
+// Returns false if the current executable is affected by stats collection

[rkaplow, 2016/08/10 20:16:29]

this is ok, but IMO would be more intuitive as



Returns true if the current executable is in the chosen sample that will report
stats and crashes.

Especially since everything else here is discussing the true output, and
currently there's a bit of double negation..

[jwd, 2016/08/10 22:10:02]

I agree the double negation is undesirable. I don't really like your comment
though because I don't like referring to clients that aren't affected by
sampling as "in the chosen sample".

Note that in Chrome, there is a functional difference between clients that
aren't affected by sampling, and those that are, and are in the sample. Namely
in-sample clients report a variation and sample rate, whereas unaffected
reporting clients don't.

But, I don't feel that strongly, so I'll change it.

+// sampling, and shouldn't be reporting stats and crashes. Otherwise, returns
+// true.
+bool GetCollectStatsInSample();
+
 // Returns true if if usage stats reporting is controlled by a mandatory
 // policy. |metrics_is_enforced_by_policy| will be set to true accordingly.
 // TODO(ananta)