Adding support for sampling crashes in Chrome on Windows.

chrome/install_static/install_util.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 // This file contains helper functions which provide information about the
 // current version of Chrome. This includes channel information, version
 // information etc. This functionality is provided by using functions in
 // kernel32 and advapi32. No other dependencies are allowed in this file.
 
 #ifndef CHROME_INSTALL_STATIC_INSTALL_UTIL_H_
 #define CHROME_INSTALL_STATIC_INSTALL_UTIL_H_
@@ skipping 23 matching lines @@
 extern const wchar_t kRegPathClientStateMedium[];
 extern const wchar_t kRegPathChromePolicy[];
 extern const wchar_t kRegApField[];
 extern const wchar_t kRegValueUsageStats[];
 extern const wchar_t kUninstallArgumentsField[];
 extern const wchar_t kMetricsReportingEnabled[];
 extern const wchar_t kAppGuidCanary[];
 extern const wchar_t kAppGuidGoogleChrome[];
 extern const wchar_t kAppGuidGoogleBinaries[];
 
+extern const wchar_t kChromeMetrics[];
+extern const wchar_t kChromeStatsSampleKey[];

[Alexei Svitkine (slow), 2016/08/10 21:49:33]

Are you missing the bit that sets these?

[jwd, 2016/08/11 21:41:03]

Moved setting from chrome_metrics_services_client to here.

+
 // TODO(ananta)
 // https://crbug.com/604923
 // Unify these constants with env_vars.h.
 extern const wchar_t kHeadless[];
 extern const wchar_t kShowRestart[];
 extern const wchar_t kRestartInfo[];
 extern const wchar_t kRtlLocale[];
 
 // TODO(ananta)
 // https://crbug.com/604923
@@ skipping 17 matching lines @@
 
 // Returns true if usage stats collecting is enabled for this user for the
 // current executable.
 bool GetCollectStatsConsent();
 
 // Returns true if usage stats collecting is enabled for this user for the
 // executable passed in as |exe_path|.
 // Only used by tests.
 bool GetCollectStatsConsentForTesting(const std::wstring& exe_path);
 
+// Returns false if the current executable is affected by stats collection

[rkaplow, 2016/08/10 20:16:29]

this is ok, but IMO would be more intuitive as



Returns true if the current executable is in the chosen sample that will report
stats and crashes.

Especially since everything else here is discussing the true output, and
currently there's a bit of double negation..

[jwd, 2016/08/10 22:10:02]

I agree the double negation is undesirable. I don't really like your comment
though because I don't like referring to clients that aren't affected by
sampling as "in the chosen sample".

Note that in Chrome, there is a functional difference between clients that
aren't affected by sampling, and those that are, and are in the sample. Namely
in-sample clients report a variation and sample rate, whereas unaffected
reporting clients don't.

But, I don't feel that strongly, so I'll change it.

+// sampling, and shouldn't be reporting stats and crashes. Otherwise, returns
+// true.
+bool GetCollectStatsInSample();
+
 // Returns true if if usage stats reporting is controlled by a mandatory
 // policy. |metrics_is_enforced_by_policy| will be set to true accordingly.
 // TODO(ananta)
 // Make this function private to install_util.
 bool ReportingIsEnforcedByPolicy(bool* metrics_is_enforced_by_policy);
 
 // Initializes |g_process_type| which stores whether or not the current
 // process is the main browser process.
 void InitializeProcessType();
 
@@ skipping 116 matching lines @@
 // value of the |switch_name| passed in.
 std::string GetSwitchValueFromCommandLine(const std::string& command_line,
                                           const std::string& switch_name);
 
 // Caches the |ProcessType| of the current process.
 extern ProcessType g_process_type;
 
 }  // namespace install_static
 
 #endif  // CHROME_INSTALL_STATIC_INSTALL_UTIL_H_