Issue 2221783004: TypingCommand should not cancel previous spellcheck request if no new request in initiated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2221783004: TypingCommand should not cancel previous spellcheck request if no new request in initiated (Closed)

Created:
4 years, 4 months ago by Xiaocheng

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews, blink-reviews, groby+blinkspell_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

TypingCommand should not cancel previous spellcheck request if no new request in initiated This patch ensures that when typing, the previous spellcheck request is canceled only if a new request is initiated. In addtion, the call to SpellCheckRequester::cancelCheck should only happen when unified text checker is enabled. BUG=635452 TEST=editing/spelling/check_after_consecutive_inserttext_commands.html

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -2 lines)			Patch
A	third_party/WebKit/LayoutTests/editing/spelling/check_after_consecutive_inserttext_commands.html	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Xiaocheng

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

4 years, 4 months ago (2016-08-08 13:25:56 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221783004/1

4 years, 4 months ago (2016-08-08 13:26:13 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 4 months ago (2016-08-08 14:16:02 UTC) #3

commit-bot: I haz the power

4 years, 4 months ago (2016-08-08 14:16:03 UTC) #4

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages