third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp - Issue 2221783004: TypingCommand should not cancel previous spellcheck request if no new request in initiated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

Issue 2221783004: TypingCommand should not cancel previous spellcheck request if no new request in initiated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/spelling/check_after_consecutive_inserttext_commands.html ('k') | third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp b/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

index 537b0e9fd09e670f85ab955226b89216a8911b7f..fe6b0d713bf3e29cd291183f133f1259bd2e3be1 100644

--- a/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

@@ -337,8 +337,6 @@ void TypingCommand::markMisspellingsAfterTyping(ETypingCommand commandType)

if (!SpellChecker::isSpellCheckingEnabledFor(endingSelection()))

return;

- frame->spellChecker().cancelCheck();

// Take a look at the selection that results after typing and determine whether we need to spellcheck.

// Since the word containing the current selection is never marked, this does a check to

// see if typing made a new word that is not in the current selection. Basically, you