Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2221473002: Revert of [x64] Zero/sign-extend loads to 64-bit registers. (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [x64] Zero/sign-extend loads to 64-bit registers. (patchset #1 id:20001 of https://codereview.chromium.org/2220483003/ ) Reason for revert: Breaks tree: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/10969 Original issue's description: > [x64] Zero/sign-extend loads to 64-bit registers. > > Before this change we would first load an 8/16/32-bit value from memory into a 32-bit register, then zero/sign-extend from that register to a 64-bit one. Now we replace that pattern with a single movsx/movzx. > > Ported from http://crrev.com/2183923003 > > R=bmeurer@chromium.org > > Committed: https://crrev.com/4abecb7a27bd5fa073d0ff5fadb0c2bb248ef9f4 > Cr-Commit-Position: refs/heads/master@{#38388} TBR=bmeurer@chromium.org,epertoso@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/0f4468b4a6ce8eeba5608e2958e6838c26d88f71 Cr-Commit-Position: refs/heads/master@{#38389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -105 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/x64/instruction-scheduler-x64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +1 line, -30 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M test/unittests/compiler/x64/instruction-selector-x64-unittest.cc View 2 chunks +1 line, -35 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [x64] Zero/sign-extend loads to 64-bit registers.
4 years, 4 months ago (2016-08-05 14:27:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221473002/1
4 years, 4 months ago (2016-08-05 14:27:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 14:27:23 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 14:30:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f4468b4a6ce8eeba5608e2958e6838c26d88f71
Cr-Commit-Position: refs/heads/master@{#38389}

Powered by Google App Engine
This is Rietveld 408576698