Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2221393002: EnrollmentConfig: Switch to default constructor and in-class initialization. (Closed)

Created:
4 years, 4 months ago by Thiemo Nagel
Modified:
4 years, 4 months ago
Reviewers:
peletskyi
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org, The one and only Dr. Crash
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

EnrollmentConfig: Switch to default constructor and in-class initialization. BUG=none Committed: https://crrev.com/7f5b116733239a8493cf30fb0ce9b40f3f3ccb7c Cr-Commit-Position: refs/heads/master@{#411301}

Patch Set 1 #

Patch Set 2 : Re-instate TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -21 lines) Patch
M chrome/browser/chromeos/policy/enrollment_config.h View 1 3 chunks +3 lines, -5 lines 0 comments Download
D chrome/browser/chromeos/policy/enrollment_config.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Thiemo Nagel
Hi Sasha, could you please take a look? Thank you! Thiemo
4 years, 4 months ago (2016-08-09 15:27:31 UTC) #2
Thiemo Nagel
4 years, 4 months ago (2016-08-09 15:27:50 UTC) #3
peletskyi
On 2016/08/09 15:27:50, Thiemo Nagel wrote: LGTM
4 years, 4 months ago (2016-08-11 10:31:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221393002/20001
4 years, 4 months ago (2016-08-11 10:32:05 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 11:19:18 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 11:21:20 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7f5b116733239a8493cf30fb0ce9b40f3f3ccb7c
Cr-Commit-Position: refs/heads/master@{#411301}

Powered by Google App Engine
This is Rietveld 408576698