Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2221373002: Modify PasswordEntryEditor layout to remove warnings (Closed)

Created:
4 years, 4 months ago by dozsa
Modified:
4 years, 4 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify PasswordEntryEditor layout to remove warnings This CL removes two warnings generated by the changes made to PasswordEntryEditor: chrome/android/java/res/layout/password_entry_editor.xml:68 Cancel button should be on the left (was "Delete | Cancel", should be "Cancel | Delete"): ButtonOrder [warning] chrome/android/java/res/layout/password_entry_editor_interactive.xml:89 [Accessibility] Missing `contentDescription` attribute on image: ContentDescription [warning] BUG=619868 Committed: https://crrev.com/04e1ab8bc32ae548c07791a27a62c87eb6961097 Cr-Commit-Position: refs/heads/master@{#411017}

Patch Set 1 #

Patch Set 2 : Remove contentDescription from TextView #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/android/java/res/layout/password_entry_editor.xml View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/android/java/res/layout/password_entry_editor_interactive.xml View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
dozsa
Hello, Could you please review the changes made in this CL? Best, Paula
4 years, 4 months ago (2016-08-09 14:13:38 UTC) #3
Yusuf
lgtm
4 years, 4 months ago (2016-08-09 20:29:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221373002/20001
4 years, 4 months ago (2016-08-10 08:06:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 10:11:07 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 10:12:33 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04e1ab8bc32ae548c07791a27a62c87eb6961097
Cr-Commit-Position: refs/heads/master@{#411017}

Powered by Google App Engine
This is Rietveld 408576698