Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: chrome/android/java/res/layout/password_entry_editor_interactive.xml

Issue 2221373002: Modify PasswordEntryEditor layout to remove warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove contentDescription from TextView Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/java/res/layout/password_entry_editor.xml ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2016 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <ScrollView xmlns:android="http://schemas.android.com/apk/res/android" 6 <ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
7 android:layout_width="match_parent" 7 android:layout_width="match_parent"
8 android:layout_height="match_parent" 8 android:layout_height="match_parent"
9 android:fillViewport="true" > 9 android:fillViewport="true" >
10 10
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 android:layout_height="wrap_content" 71 android:layout_height="wrap_content"
72 android:orientation="horizontal"> 72 android:orientation="horizontal">
73 73
74 <TextView 74 <TextView
75 android:id="@+id/password_entry_editor_name" 75 android:id="@+id/password_entry_editor_name"
76 android:textColor="@color/default_text_color" 76 android:textColor="@color/default_text_color"
77 android:layout_width="fill_parent" 77 android:layout_width="fill_parent"
78 android:layout_height="wrap_content" 78 android:layout_height="wrap_content"
79 android:layout_marginTop="10dp" 79 android:layout_marginTop="10dp"
80 android:layout_marginStart="15dp" 80 android:layout_marginStart="15dp"
81 android:textAppearance="?android:attr/textAppearanceMedium" 81 android:textAppearance="?android:attr/textAppearanceMedium" />
82 android:contentDescription="@string/password_entry_editor_copy_s tored_username" />
83 82
84 <View 83 <View
85 android:layout_width="0dp" 84 android:layout_width="0dp"
86 android:layout_height="0dp" 85 android:layout_height="0dp"
87 android:layout_weight="1" /> 86 android:layout_weight="1" />
88 87
89 <ImageButton 88 <ImageButton
90 style="?android:attr/buttonStyleSmall" 89 style="?android:attr/buttonStyleSmall"
91 android:layout_width="match_parent" 90 android:layout_width="match_parent"
92 android:layout_height="wrap_content" 91 android:layout_height="wrap_content"
93 android:layout_gravity="end" 92 android:layout_gravity="end"
94 android:layout_marginTop="10dp" 93 android:layout_marginTop="10dp"
95 android:layout_marginEnd="15dp" 94 android:layout_marginEnd="15dp"
96 android:src="@drawable/ic_content_copy" /> 95 android:src="@drawable/ic_content_copy"
96 android:contentDescription="@string/password_entry_editor_copy_s tored_username" />
97 97
98 </LinearLayout> 98 </LinearLayout>
99 99
100 <TextView 100 <TextView
101 android:text="@string/password_entry_editor_password" 101 android:text="@string/password_entry_editor_password"
102 android:textColor="@color/google_blue_700" 102 android:textColor="@color/google_blue_700"
103 android:layout_width="wrap_content" 103 android:layout_width="wrap_content"
104 android:layout_height="wrap_content" 104 android:layout_height="wrap_content"
105 android:layout_marginTop="5dp" 105 android:layout_marginTop="5dp"
106 android:layout_marginStart="15dp" 106 android:layout_marginStart="15dp"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 android:layout_marginTop="10dp" 144 android:layout_marginTop="10dp"
145 android:layout_marginEnd="15dp" 145 android:layout_marginEnd="15dp"
146 android:src="@drawable/ic_content_copy" 146 android:src="@drawable/ic_content_copy"
147 android:contentDescription="@string/password_entry_editor_copy_s tored_password" /> 147 android:contentDescription="@string/password_entry_editor_copy_s tored_password" />
148 148
149 </LinearLayout> 149 </LinearLayout>
150 150
151 </LinearLayout> 151 </LinearLayout>
152 152
153 </ScrollView> 153 </ScrollView>
OLDNEW
« no previous file with comments | « chrome/android/java/res/layout/password_entry_editor.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698