[debugger] reapply break points after clearing one shots.

[debugger] reapply break points after clearing one shots.

On the debug info, we have a list of existing break points.  When we
step in the debugger, we flood the function with one-shot break points.
Afterwards, we clear these one-shots by clearing all break locations.

Previously, while clearing break locations, we would skip ones that have
actual break points. Now we clear all break locations, and then reapply
break points. This is necessary for the next step, when we encode break
point info by source position, and not code offset. Encoding by code
offset would mean that break points are dependent on the code kind we
use.

R=jgruber@chromium.org
BUG=v8:5265
Committed: https://crrev.com/808981a22ee19461bbe981ab33b58792d991533e
Cr-Commit-Position: refs/heads/master@{#38492}

[jgruber, 2016-08-09 09:46:30]

lgtm

[Yang, 2016-08-09 12:17:19]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-08-09 12:17:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 13:04:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-09 13:04:23]

Description was changed from

==========
[debugger] reapply break points after clearing one shots.

On the debug info, we have a list of existing break points.  When we
step in the debugger, we flood the function with one-shot break points.
Afterwards, we clear these one-shots by clearing all break locations.

Previously, while clearing break locations, we would skip ones that have
actual break points. Now we clear all break locations, and then reapply
break points. This is necessary for the next step, when we encode break
point info by source position, and not code offset. Encoding by code
offset would mean that break points are dependent on the code kind we
use.

R=jgruber@chromium.org
BUG=v8:5265
==========

to

==========
[debugger] reapply break points after clearing one shots.

On the debug info, we have a list of existing break points.  When we
step in the debugger, we flood the function with one-shot break points.
Afterwards, we clear these one-shots by clearing all break locations.

Previously, while clearing break locations, we would skip ones that have
actual break points. Now we clear all break locations, and then reapply
break points. This is necessary for the next step, when we encode break
point info by source position, and not code offset. Encoding by code
offset would mean that break points are dependent on the code kind we
use.

R=jgruber@chromium.org
BUG=v8:5265

Committed: https://crrev.com/808981a22ee19461bbe981ab33b58792d991533e
Cr-Commit-Position: refs/heads/master@{#38492}
==========

[commit-bot: I haz the power, 2016-08-09 13:04:24]

Patchset 1 (id:??) landed as
https://crrev.com/808981a22ee19461bbe981ab33b58792d991533e
Cr-Commit-Position: refs/heads/master@{#38492}

[Yang, 2016-08-10 08:22:10]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2231653003/ by yangguo@chromium.org.

The reason for reverting is: Found better solution..