Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: components/offline_pages/downloads/download_ui_adapter.h

Issue 2221293002: Implement deleteItem and openItem on OfflinePageDownloadBridge. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/downloads/download_ui_adapter.h
diff --git a/components/offline_pages/downloads/download_ui_adapter.h b/components/offline_pages/downloads/download_ui_adapter.h
index d96f11d7da757836ac0aee7a2cfc360b2a58b5e3..e64e7c6adb22cae1fa32ad7d77a0df2ffc3a22df 100644
--- a/components/offline_pages/downloads/download_ui_adapter.h
+++ b/components/offline_pages/downloads/download_ui_adapter.h
@@ -70,6 +70,12 @@ class DownloadUIAdapter : public OfflinePageModel::Observer,
// May return nullptr.
const DownloadUIItem* GetItem(const std::string& guid) const;
+ // Commands from UI. Start async operations, result is observable
+ // via Observer or directly by the user (as in 'open').
+ void DeleteItem(const std::string& guid);
+ std::string GetOfflineUrlByGuid(guid);
fgorski 2016/08/09 04:00:51 this is where it does not compile.
Dmitry Titov 2016/08/12 04:01:39 Done.
+
fgorski 2016/08/09 04:00:51 nit: remove empty line
Dmitry Titov 2016/08/12 04:01:39 Done.
+
// OfflinePageModel::Observer
void OfflinePageModelLoaded(OfflinePageModel* model) override;
void OfflinePageModelChanged(OfflinePageModel* model) override;
@@ -84,6 +90,12 @@ class DownloadUIAdapter : public OfflinePageModel::Observer,
void OnOfflinePagesLoaded(const MultipleOfflinePageItemResult& pages);
void NotifyItemsLoaded(Observer* observer);
void OnOfflinePagesChanged(const MultipleOfflinePageItemResult& pages);
+ void OnDeleteItemByGuid(
+ const MultipleOfflinePageItemResult& pages, const std::string& guid);
+ void OnDeletePagesDone(bool success);
+
+ OfflinePageItem* FindPageByGuid(
+ const MultipleOfflinePageItemResult& pages, const std::string& guid);
bool IsVisibleInUI(const OfflinePageItem& page);
// Always valid, this class is a member of the model.

Powered by Google App Engine
This is Rietveld 408576698