Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

Issue 2221293002: Implement deleteItem and openItem on OfflinePageDownloadBridge. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
diff --git a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
index 44d9827d6dd86796205b8e5d4bc80512870d7a4a..ec3dc9f3990632710d335bce35aaa66b20e9fa56 100644
--- a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
+++ b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
@@ -91,6 +91,25 @@ ScopedJavaLocalRef<jobject> OfflinePageDownloadBridge::GetItemByGuid(
return ToJavaOfflinePageDownloadItem(env, *item);
}
+void OfflinePageDownloadBridge::DeleteItemByGuid(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jstring>& j_guid) {
fgorski 2016/08/09 04:00:50 including here.
Dmitry Titov 2016/08/12 04:01:39 Done.
+ std::string guid = ConvertJavaStringToUTF8(env, j_guid);
+ download_ui_adapter_->DeleteItem(guid);
+}
+
+ScopedJavaLocalRef<jstring> OfflinePageDownloadBridge::GetOfflineUrlByGuid(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jstring>& j_guid) {
fgorski 2016/08/09 04:00:50 and here.
Dmitry Titov 2016/08/12 04:01:39 Done.
+ std::string guid = ConvertJavaStringToUTF8(env, j_guid);
+ std::string url = download_ui_adapter_->GetOfflineUrlByGuid(guid);
+ if (url.empty())
+ return ScopedJavaLocalRef<jstring>();
+ return ConvertUTF8ToJavaString(env, url);
fgorski 2016/08/09 04:00:50 It should simply work if url is empty, I don't thi
Dmitry Titov 2016/08/12 04:01:39 Done.
+}
+
void OfflinePageDownloadBridge::ItemsLoaded() {
JNIEnv* env = AttachCurrentThread();
ScopedJavaLocalRef<jobject> obj = weak_java_ref_.get(env);

Powered by Google App Engine
This is Rietveld 408576698