Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 2221253003: a few cleanups to get IDE message clean (Closed)

Created:
4 years, 4 months ago by Jennifer Messerly
Modified:
4 years, 4 months ago
Reviewers:
priscillalee
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : revert element_helpers #

Patch Set 3 : revert pubspec #

Patch Set 4 : fix copyright header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M tool/analyze.sh View 1 chunk +2 lines, -1 line 0 comments Download
M web/web_command.dart View 1 2 3 4 chunks +10 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
Just a few cleanups that IntelliJ/strong mode found
4 years, 4 months ago (2016-08-09 20:11:32 UTC) #2
priscillalee
lgtm
4 years, 4 months ago (2016-08-09 20:36:23 UTC) #3
Jennifer Messerly
4 years, 4 months ago (2016-08-09 20:40:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
a8fbbbafd8ad3fdcaf318c74ebddf6cf9d77f8e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698