Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: web/web_command.dart

Issue 2221253003: a few cleanups to get IDE message clean (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: fix copyright header Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tool/analyze.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: web/web_command.dart
diff --git a/web/web_command.dart b/web/web_command.dart
index 1c01d9953d228dc88b20c15ab6f8263ad20750ce..8b67a3a63bc89d04833f16e5cb2b833c44b97223 100644
--- a/web/web_command.dart
+++ b/web/web_command.dart
@@ -9,25 +9,19 @@ import 'dart:html' show HttpRequest;
import 'dart:convert' show BASE64;
import 'package:analyzer/file_system/file_system.dart'
- show ResourceProvider, ResourceUriResolver;
+ show ResourceUriResolver;
import 'package:analyzer/file_system/memory_file_system.dart'
show MemoryResourceProvider;
-import 'package:analyzer/src/context/cache.dart'
- show AnalysisCache, CachePartition;
import 'package:analyzer/src/context/context.dart' show AnalysisContextImpl;
-import 'package:analyzer/src/generated/engine.dart'
- show AnalysisContext, AnalysisEngine, TimestampedData;
-import 'package:analyzer/src/generated/sdk.dart'
- show DartSdk, SdkLibrary, SdkLibraryImpl;
import 'package:analyzer/src/generated/source.dart'
- show DartUriResolver, Source, SourceFactory, UriKind;
+ show DartUriResolver;
import 'package:analyzer/src/summary/idl.dart' show PackageBundle;
import 'package:analyzer/src/summary/package_bundle_reader.dart'
show
- SummaryDataStore,
- InSummaryPackageUriResolver,
- InputPackagesResultProvider,
- InSummarySource;
+ SummaryDataStore,
+ InSummaryPackageUriResolver,
+ InputPackagesResultProvider,
+ InSummarySource;
import 'package:analyzer/src/summary/summary_sdk.dart' show SummaryBasedDartSdk;
import 'package:args/command_runner.dart';
@@ -43,6 +37,7 @@ typedef void MessageHandler(Object message);
/// The command for invoking the modular compiler.
class WebCompileCommand extends Command {
get name => 'compile';
+
get description => 'Compile a set of Dart files into a JavaScript module.';
final MessageHandler messageHandler;
@@ -69,7 +64,7 @@ class WebCompileCommand extends Command {
Future.wait(summaryRequests).then((summaryResponses) {
// Map summary responses to summary bytes.
- var summaryBytes = [];
+ var summaryBytes = <List<int>>[];
for (var response in summaryResponses) {
summaryBytes.add(BASE64.decode(response.responseText));
}
@@ -108,8 +103,8 @@ class WebCompileCommand extends Command {
fileResolvers: fileResolvers,
resourceProvider: resourceProvider);
- compiler.context.resultProvider =
- new InputPackagesResultProvider(compiler.context, summaryDataStore);
+ (compiler.context as AnalysisContextImpl).resultProvider =
+ new InputPackagesResultProvider(compiler.context, summaryDataStore);
var compilerOptions = new CompilerOptions.fromArguments(argResults);
« no previous file with comments | « tool/analyze.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698