Move seg_to to a new header, define SkSegType enum there

Move seg_to to a new header, define SkSegType enum there

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221203002

Committed: https://skia.googlesource.com/skia/+/23d97760248300b7aec213a36f8b0485857240b5

[Harry Stern, 2016-08-08 21:47:48]

Description was changed from

==========
Move seg_to to a new header, define SkSegType enum there

BUG=skia:
==========

to

==========
Move seg_to to a new header, define SkSegType enum there

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221203002
==========

[Harry Stern, 2016-08-08 21:49:02]

Description was changed from

==========
Move seg_to to a new header, define SkSegType enum there

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221203002
==========

to

==========
Move seg_to to a new header, define SkSegType enum there

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221203002
==========

[Harry Stern, 2016-08-08 21:49:02]

hstern@google.com changed reviewers:
+ reed@google.com

[Harry Stern, 2016-08-08 21:49:18]

The CQ bit was checked by hstern@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 21:49:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 21:54:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 21:54:56]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)

[Harry Stern, 2016-08-08 21:57:56]

The CQ bit was checked by hstern@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 21:58:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 22:19:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 22:19:46]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-08-09 14:07:28]

lgtm w/ naming nit

https://codereview.chromium.org/2221203002/diff/20001/src/core/SkPathMeasureP...
File src/core/SkPathMeasurePriv.h (right):

https://codereview.chromium.org/2221203002/diff/20001/src/core/SkPathMeasureP...
src/core/SkPathMeasurePriv.h:26: void addSegmentToPath(const SkPoint pts[],
unsigned segType,
Lets guard the name more: e.g. SkPathMeasure_addSeg to make it harder for a
caller to use the same function name.

[Harry Stern, 2016-08-09 15:39:44]

On 2016/08/09 14:07:28, reed1 wrote:
> lgtm w/ naming nit
> 
>
https://codereview.chromium.org/2221203002/diff/20001/src/core/SkPathMeasureP...
> File src/core/SkPathMeasurePriv.h (right):
> 
>
https://codereview.chromium.org/2221203002/diff/20001/src/core/SkPathMeasureP...
> src/core/SkPathMeasurePriv.h:26: void addSegmentToPath(const SkPoint pts[],
> unsigned segType,
> Lets guard the name more: e.g. SkPathMeasure_addSeg to make it harder for a
> caller to use the same function name.

I don't understand what you mean. They'd have to include the SkPathMeasurePriv
header or have a function with precisely the same type signature to get a
collision (if that's what you're talking about) right?

[reed1, 2016-08-09 15:40:54]

correct

[Harry Stern, 2016-08-09 16:06:41]

On 2016/08/09 15:40:54, reed1 wrote:
> correct

Done.

[Harry Stern, 2016-08-09 16:06:55]

The CQ bit was checked by hstern@google.com

[Harry Stern, 2016-08-09 16:06:55]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/2221203002/#ps40001
(title: "Rename addSegmentToPath to SkPathMeasure_segTo")

[commit-bot: I haz the power, 2016-08-09 16:07:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 16:38:32]

Description was changed from

==========
Move seg_to to a new header, define SkSegType enum there

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221203002
==========

to

==========
Move seg_to to a new header, define SkSegType enum there

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221203002

Committed:
https://skia.googlesource.com/skia/+/23d97760248300b7aec213a36f8b0485857240b5
==========

[commit-bot: I haz the power, 2016-08-09 16:38:33]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/23d97760248300b7aec213a36f8b0485857240b5