Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2221083002: Revert of Reland #1: "base: Implement GetCurrentThreadPriority." (Closed)

Created:
4 years, 4 months ago by erikchen
Modified:
4 years, 4 months ago
Reviewers:
Mark Mentovai, gab
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland #1: "base: Implement GetCurrentThreadPriority." (patchset #2 id:20001 of https://codereview.chromium.org/2215513002/ ) Reason for revert: Still causes startup regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=635464#c4 Original issue's description: > Reland #1: "base: Implement GetCurrentThreadPriority." > > The Chrome thread priority is saved in the thread dictionary during > SetCurrentThreadPriority(). This seemed a better approach than using > thread_policy_get(), since there are 4 Chrome priorities which won't cleanly map > to thread flavors. > > BUG=601270 > > Committed: https://crrev.com/23d10a36f2e815edd610098a65e5890f279d2183 > Cr-Commit-Position: refs/heads/master@{#410163} TBR=mark@chromium.org,gab@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=601270 Committed: https://crrev.com/23c669b5b4cf228dab6da2cc47293b4650a7b923 Cr-Commit-Position: refs/heads/master@{#410390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M base/threading/platform_thread_mac.mm View 1 chunk +4 lines, -3 lines 0 comments Download
M base/threading/platform_thread_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/startup_metric_utils/browser/startup_metric_utils.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
erikchen
Created Revert of Reland #1: "base: Implement GetCurrentThreadPriority."
4 years, 4 months ago (2016-08-08 17:11:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221083002/1
4 years, 4 months ago (2016-08-08 17:12:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 17:53:00 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 17:56:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23c669b5b4cf228dab6da2cc47293b4650a7b923
Cr-Commit-Position: refs/heads/master@{#410390}

Powered by Google App Engine
This is Rietveld 408576698