Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2215513002: Reland #1: "base: Implement GetCurrentThreadPriority." (Closed)

Created:
4 years, 4 months ago by erikchen
Modified:
4 years, 4 months ago
Reviewers:
Mark Mentovai, gab
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #1: "base: Implement GetCurrentThreadPriority." The Chrome thread priority is saved in the thread dictionary during SetCurrentThreadPriority(). This seemed a better approach than using thread_policy_get(), since there are 4 Chrome priorities which won't cleanly map to thread flavors. BUG=601270 Committed: https://crrev.com/23d10a36f2e815edd610098a65e5890f279d2183 Cr-Commit-Position: refs/heads/master@{#410163}

Patch Set 1 #

Patch Set 2 : REbase error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M base/threading/platform_thread_mac.mm View 1 chunk +2 lines, -3 lines 0 comments Download
M base/threading/platform_thread_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M components/startup_metric_utils/browser/startup_metric_utils.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
erikchen
mark, gab: Please review. I reran the failed Telemetry tests locally (10.11.6) and no longer ...
4 years, 4 months ago (2016-08-05 17:17:42 UTC) #6
Mark Mentovai
Go for it, hope it sticks. What OS version do we run perf tests on?
4 years, 4 months ago (2016-08-05 17:29:47 UTC) #7
Mark Mentovai
I guess the infrastructure doesn’t recognize “go for it” as LGTM.
4 years, 4 months ago (2016-08-05 17:30:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215513002/20001
4 years, 4 months ago (2016-08-05 20:17:06 UTC) #10
gab
lgtm if it works, what changed though, why would it be fine now, I don't ...
4 years, 4 months ago (2016-08-05 20:34:21 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-05 21:16:33 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/23d10a36f2e815edd610098a65e5890f279d2183 Cr-Commit-Position: refs/heads/master@{#410163}
4 years, 4 months ago (2016-08-05 21:19:41 UTC) #14
erikchen
On 2016/08/05 20:34:21, gab wrote: > lgtm if it works, what changed though, why would ...
4 years, 4 months ago (2016-08-05 21:23:53 UTC) #15
erikchen
4 years, 4 months ago (2016-08-08 17:11:38 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2221083002/ by erikchen@chromium.org.

The reason for reverting is: Still causes startup regressions:

https://bugs.chromium.org/p/chromium/issues/detail?id=635464#c4.

Powered by Google App Engine
This is Rietveld 408576698