Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2221043002: [turbofan] Remove unused Type parameter from ReferenceEqual. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove unused Type parameter from ReferenceEqual. This parameter was never used and doesn't seem like it would ever be useful, so it's gone now. R=epertoso@chromium.org Committed: https://crrev.com/5afd1f303dd29fbc2fc474618f3cd0048217716b Cr-Commit-Position: refs/heads/master@{#38453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -71 lines) Patch
M src/compiler/js-call-reducer.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/js-global-object-specialization.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 8 chunks +27 lines, -39 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 2 chunks +1 line, -6 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-08 15:21:35 UTC) #1
Benedikt Meurer
Hey Enrico, Dead code should be dead. Please take a look. Thanks, Benedikt
4 years, 4 months ago (2016-08-08 15:21:59 UTC) #4
epertoso
lgtm That is not dead which can eternal lie. And with strange aeons even death ...
4 years, 4 months ago (2016-08-08 15:39:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221043002/1
4 years, 4 months ago (2016-08-08 16:30:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 16:32:32 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 16:34:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5afd1f303dd29fbc2fc474618f3cd0048217716b
Cr-Commit-Position: refs/heads/master@{#38453}

Powered by Google App Engine
This is Rietveld 408576698