Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: src/compiler/js-global-object-specialization.cc

Issue 2221043002: [turbofan] Remove unused Type parameter from ReferenceEqual. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-create-lowering.cc ('k') | src/compiler/js-native-context-specialization.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/js-global-object-specialization.h" 5 #include "src/compiler/js-global-object-specialization.h"
6 6
7 #include "src/compilation-dependencies.h" 7 #include "src/compilation-dependencies.h"
8 #include "src/compiler/access-builder.h" 8 #include "src/compiler/access-builder.h"
9 #include "src/compiler/common-operator.h" 9 #include "src/compiler/common-operator.h"
10 #include "src/compiler/js-graph.h" 10 #include "src/compiler/js-graph.h"
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 // Don't even bother trying to lower stores to read-only data properties. 162 // Don't even bother trying to lower stores to read-only data properties.
163 if (property_details.IsReadOnly()) return NoChange(); 163 if (property_details.IsReadOnly()) return NoChange();
164 switch (property_details.cell_type()) { 164 switch (property_details.cell_type()) {
165 case PropertyCellType::kUndefined: { 165 case PropertyCellType::kUndefined: {
166 return NoChange(); 166 return NoChange();
167 } 167 }
168 case PropertyCellType::kConstant: { 168 case PropertyCellType::kConstant: {
169 // Record a code dependency on the cell, and just deoptimize if the new 169 // Record a code dependency on the cell, and just deoptimize if the new
170 // value doesn't match the previous value stored inside the cell. 170 // value doesn't match the previous value stored inside the cell.
171 dependencies()->AssumePropertyCell(property_cell); 171 dependencies()->AssumePropertyCell(property_cell);
172 Node* check = 172 Node* check = graph()->NewNode(simplified()->ReferenceEqual(), value,
173 graph()->NewNode(simplified()->ReferenceEqual(Type::Tagged()), value, 173 jsgraph()->Constant(property_cell_value));
174 jsgraph()->Constant(property_cell_value));
175 effect = 174 effect =
176 graph()->NewNode(simplified()->CheckIf(), check, effect, control); 175 graph()->NewNode(simplified()->CheckIf(), check, effect, control);
177 break; 176 break;
178 } 177 }
179 case PropertyCellType::kConstantType: { 178 case PropertyCellType::kConstantType: {
180 // Record a code dependency on the cell, and just deoptimize if the new 179 // Record a code dependency on the cell, and just deoptimize if the new
181 // values' type doesn't match the type of the previous value in the cell. 180 // values' type doesn't match the type of the previous value in the cell.
182 dependencies()->AssumePropertyCell(property_cell); 181 dependencies()->AssumePropertyCell(property_cell);
183 Type* property_cell_value_type; 182 Type* property_cell_value_type;
184 if (property_cell_value->IsHeapObject()) { 183 if (property_cell_value->IsHeapObject()) {
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 } 272 }
274 273
275 274
276 SimplifiedOperatorBuilder* JSGlobalObjectSpecialization::simplified() const { 275 SimplifiedOperatorBuilder* JSGlobalObjectSpecialization::simplified() const {
277 return jsgraph()->simplified(); 276 return jsgraph()->simplified();
278 } 277 }
279 278
280 } // namespace compiler 279 } // namespace compiler
281 } // namespace internal 280 } // namespace internal
282 } // namespace v8 281 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/js-create-lowering.cc ('k') | src/compiler/js-native-context-specialization.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698