Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2220963002: Add trailing comma support to changelog (Closed)

Created:
4 years, 4 months ago by mit
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporated feedback #

Patch Set 3 : Fix formatting #

Patch Set 4 : Fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M CHANGELOG.md View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
mit
4 years, 4 months ago (2016-08-08 08:21:45 UTC) #2
Lasse Reichstein Nielsen
https://codereview.chromium.org/2220963002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2220963002/diff/1/CHANGELOG.md#newcode5 CHANGELOG.md:5: * The language now allows a final argument or ...
4 years, 4 months ago (2016-08-08 08:30:54 UTC) #3
Lasse Reichstein Nielsen
lgtm
4 years, 4 months ago (2016-08-08 08:31:03 UTC) #4
mit
Committed patchset #1 (id:1) manually as 8770a64d91dbaf3dbb1bfcd9280bf97c77eb3a28 (presubmit successful).
4 years, 4 months ago (2016-08-08 08:42:20 UTC) #6
mit
On 2016/08/08 08:42:20, mit wrote: > Committed patchset #1 (id:1) manually as > 8770a64d91dbaf3dbb1bfcd9280bf97c77eb3a28 (presubmit ...
4 years, 4 months ago (2016-08-08 09:04:07 UTC) #7
mit
Sorry, missed feedback, adding now https://codereview.chromium.org/2220963002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2220963002/diff/1/CHANGELOG.md#newcode5 CHANGELOG.md:5: * The language now ...
4 years, 4 months ago (2016-08-08 09:04:18 UTC) #8
mit
Committed patchset #2 (id:20001) manually as 06ccf2882c57765534890342ab064a86bdb4f7d8 (presubmit successful).
4 years, 4 months ago (2016-08-08 09:04:52 UTC) #10
mit
4 years, 4 months ago (2016-08-08 09:08:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
74826133511b0c9396f107eb3024253d31313985 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698