Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2220883002: Revert of Always local fallback for message_names.cc (Closed)

Created:
4 years, 4 months ago by shinyak
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Always local fallback for message_names.cc (patchset #4 id:60001 of https://codereview.chromium.org/2197083002/ ) Reason for revert: No need to do workaround thanks to https://codereview.chromium.org/2214713003 Original issue's description: > Always local fallback for message_names.cc > > On Mac, compile for tools/ipc_fuzzer/message_lib/message_names.cc is > always time out with goma. > > If compile takes more than 10 minutes on goma executor, goma returns > error because of timeout. The compile for this file always spends more > than 10 minutes to wait for response from goma server, and it's re-run > locally after the timeout. > > Let's make it local fallback always to make build faster. > > BUG=630502 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/fbd5dc3864acb34635f84586470c14cc06cf09d9 TBR=yyanagisawa@chromium.org,ukai@chromium.org,tikuta@chromium.org,shinyak@google.com,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=630502 Committed: https://chromium.googlesource.com/chromium/tools/build/+/3275ec310356a12a988182fe0103906f4a35df34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M scripts/slave/compile.py View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
shinyak
Created Revert of Always local fallback for message_names.cc
4 years, 4 months ago (2016-08-08 01:33:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220883002/1
4 years, 4 months ago (2016-08-08 01:33:35 UTC) #3
Nico
lgtm, thanks!
4 years, 4 months ago (2016-08-08 01:36:51 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 01:40:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/3275ec310356a12a9881...

Powered by Google App Engine
This is Rietveld 408576698