Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2214713003: Make message_names.cc build 10-30x faster. (Closed)

Created:
4 years, 4 months ago by Nico
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make message_names.cc build 6-30x faster. MessageNames uses two std::map<>s where std::unordered_map<>s suffice. Changing this also happens to work around a clang bug that causes very slow compile times -- see the linked bug and also http://llvm.org/PR28820 On my laptop, the file now builds in 10s instead of 67s without debug info and in 20s instead of 10m (!) with debug info. BUG=630502 Committed: https://crrev.com/7928cc2c14f71116bce5bd74d6c081be292082c8 Cr-Commit-Position: refs/heads/master@{#409852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/ipc_fuzzer/message_lib/message_names.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Nico
First to stamp wins!
4 years, 4 months ago (2016-08-04 18:10:42 UTC) #2
Martin Barbella
lgtm, thanks for investigating and fixing this.
4 years, 4 months ago (2016-08-04 18:12:19 UTC) #3
inferno
lgtm
4 years, 4 months ago (2016-08-04 18:12:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214713003/1
4 years, 4 months ago (2016-08-04 18:14:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 18:52:08 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 18:55:22 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7928cc2c14f71116bce5bd74d6c081be292082c8
Cr-Commit-Position: refs/heads/master@{#409852}

Powered by Google App Engine
This is Rietveld 408576698