Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc

Issue 2220603003: Remove unnecessary |result| argument from AllowCertificateError() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove unnecessary include Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/captive_portal_blocking_page.cc ('k') | chrome/browser/ssl/ssl_blocking_page.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc
diff --git a/chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc b/chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc
index f039c094938cffa9b4c9890405b3695998534704..844e94123f0b3fbc9c13d75401c44af3bf1989bc 100644
--- a/chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc
+++ b/chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc
@@ -67,7 +67,8 @@ class CaptivePortalBlockingPageForTesting : public CaptivePortalBlockingPage {
const GURL& login_url,
std::unique_ptr<SSLCertReporter> ssl_cert_reporter,
const net::SSLInfo& ssl_info,
- const base::Callback<void(bool)>& callback,
+ const base::Callback<void(content::CertificateRequestResultType)>&
+ callback,
bool is_wifi,
const std::string& wifi_ssid)
: CaptivePortalBlockingPage(web_contents,
@@ -140,8 +141,9 @@ void CaptivePortalBlockingPageTest::TestInterstitial(
CaptivePortalBlockingPage* blocking_page =
new CaptivePortalBlockingPageForTesting(
contents, GURL(kBrokenSSL), login_url, std::move(ssl_cert_reporter),
- ssl_info, base::Callback<void(bool)>(), is_wifi_connection,
- wifi_ssid);
+ ssl_info,
+ base::Callback<void(content::CertificateRequestResultType)>(),
+ is_wifi_connection, wifi_ssid);
blocking_page->Show();
WaitForInterstitialAttach(contents);
@@ -318,7 +320,8 @@ class CaptivePortalBlockingPageIDNTest : public SecurityInterstitialIDNTest {
CaptivePortalBlockingPage* blocking_page =
new CaptivePortalBlockingPageForTesting(
contents, GURL(kBrokenSSL), request_url, nullptr, empty_ssl_info,
- base::Callback<void(bool)>(), false, "");
+ base::Callback<void(content::CertificateRequestResultType)>(),
+ false, "");
return blocking_page;
}
};
« no previous file with comments | « chrome/browser/ssl/captive_portal_blocking_page.cc ('k') | chrome/browser/ssl/ssl_blocking_page.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698