chrome/browser/ssl/captive_portal_blocking_page.cc - Issue 2220603003: Remove unnecessary |result| argument from AllowCertificateError()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/captive_portal_blocking_page.cc

Issue 2220603003: Remove unnecessary |result| argument from AllowCertificateError() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove unnecessary include Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ssl/captive_portal_blocking_page.h ('k') | chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/captive_portal_blocking_page.cc

diff --git a/chrome/browser/ssl/captive_portal_blocking_page.cc b/chrome/browser/ssl/captive_portal_blocking_page.cc

index 3b5483a02726b9c197d4d1c89b15ed395cf6df72..89d46df8605fa772f76fc5b85c225917ad79728e 100644

--- a/chrome/browser/ssl/captive_portal_blocking_page.cc

+++ b/chrome/browser/ssl/captive_portal_blocking_page.cc

@@ -55,7 +55,7 @@ CaptivePortalBlockingPage::CaptivePortalBlockingPage(

const GURL& login_url,

std::unique_ptr<SSLCertReporter> ssl_cert_reporter,

const net::SSLInfo& ssl_info,

- const base::Callback<void(bool)>& callback)

+ const base::Callback<void(content::CertificateRequestResultType)>& callback)

: SecurityInterstitialPage(web_contents, request_url),

login_url_(login_url),

callback_(callback) {

@@ -220,7 +220,7 @@ void CaptivePortalBlockingPage::OnDontProceed() {

// Need to explicity deny the certificate via the callback, otherwise memory

// is leaked.

if (!callback_.is_null()) {

- callback_.Run(false);

+ callback_.Run(content::CERTIFICATE_REQUEST_RESULT_TYPE_CANCEL);

callback_.Reset();

}