Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7827)

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model.cc

Issue 2220573004: Caption for the Subresource filter bubble prompt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: xib Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/content_settings/content_setting_bubble_model.cc
diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model.cc b/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
index 1b76e6c8e7564a25d736a1cd3370bc5d88b9caa1..82b123f3659d37476a7ce9b2201a4eabaee0a6e7 100644
--- a/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
@@ -1177,10 +1177,10 @@ ContentSettingSubresourceFilterBubbleModel::
~ContentSettingSubresourceFilterBubbleModel() {}
void ContentSettingSubresourceFilterBubbleModel::SetTitle() {
- // TODO(melandory): For this bubble we need to introduce ability to have a
- // caption (something which appears above title and has bigger font).
set_title(l10n_util::GetStringUTF8(
IDS_FILTERED_DECEPTIVE_CONTENT_PROMPT_EXPLANATION));
+ set_caption(
+ l10n_util::GetStringUTF8(IDS_FILTERED_DECEPTIVE_CONTENT_PROMPT_TITLE));
msw 2016/08/09 19:46:54 Can you make this the title, and make IDS_FILTERED
melandory 2016/08/10 14:55:07 Talked with out UX, so we're fine having title and
}
void ContentSettingSubresourceFilterBubbleModel::SetManageLink() {

Powered by Google App Engine
This is Rietveld 408576698