Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: chrome/browser/ui/content_settings/content_setting_bubble_model.cc

Issue 2220573004: Caption for the Subresource filter bubble prompt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: xib Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/content_settings/content_setting_bubble_model.h" 5 #include "chrome/browser/ui/content_settings/content_setting_bubble_model.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 1159 matching lines...) Expand 10 before | Expand all | Expand 10 after
1170 Profile* profile) 1170 Profile* profile)
1171 : ContentSettingBubbleModel(delegate, web_contents, profile) { 1171 : ContentSettingBubbleModel(delegate, web_contents, profile) {
1172 SetTitle(); 1172 SetTitle();
1173 SetManageLink(); 1173 SetManageLink();
1174 } 1174 }
1175 1175
1176 ContentSettingSubresourceFilterBubbleModel:: 1176 ContentSettingSubresourceFilterBubbleModel::
1177 ~ContentSettingSubresourceFilterBubbleModel() {} 1177 ~ContentSettingSubresourceFilterBubbleModel() {}
1178 1178
1179 void ContentSettingSubresourceFilterBubbleModel::SetTitle() { 1179 void ContentSettingSubresourceFilterBubbleModel::SetTitle() {
1180 // TODO(melandory): For this bubble we need to introduce ability to have a
1181 // caption (something which appears above title and has bigger font).
1182 set_title(l10n_util::GetStringUTF8( 1180 set_title(l10n_util::GetStringUTF8(
1183 IDS_FILTERED_DECEPTIVE_CONTENT_PROMPT_EXPLANATION)); 1181 IDS_FILTERED_DECEPTIVE_CONTENT_PROMPT_EXPLANATION));
1182 set_caption(
1183 l10n_util::GetStringUTF8(IDS_FILTERED_DECEPTIVE_CONTENT_PROMPT_TITLE));
msw 2016/08/09 19:46:54 Can you make this the title, and make IDS_FILTERED
melandory 2016/08/10 14:55:07 Talked with out UX, so we're fine having title and
1184 } 1184 }
1185 1185
1186 void ContentSettingSubresourceFilterBubbleModel::SetManageLink() { 1186 void ContentSettingSubresourceFilterBubbleModel::SetManageLink() {
1187 // TODO(melandory): introduce the button instead of link. 1187 // TODO(melandory): introduce the button instead of link.
1188 set_manage_link( 1188 set_manage_link(
1189 l10n_util::GetStringUTF8(IDS_FILTERED_DECEPTIVE_CONTENT_PROMPT_RELOAD)); 1189 l10n_util::GetStringUTF8(IDS_FILTERED_DECEPTIVE_CONTENT_PROMPT_RELOAD));
1190 } 1190 }
1191 1191
1192 void ContentSettingSubresourceFilterBubbleModel::OnManageLinkClicked() { 1192 void ContentSettingSubresourceFilterBubbleModel::OnManageLinkClicked() {
1193 // TODO(melandory): Notify ContentSubresourceFilterDriverFactory page reload 1193 // TODO(melandory): Notify ContentSubresourceFilterDriverFactory page reload
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
1399 ContentSettingMediaStreamBubbleModel* 1399 ContentSettingMediaStreamBubbleModel*
1400 ContentSettingBubbleModel::AsMediaStreamBubbleModel() { 1400 ContentSettingBubbleModel::AsMediaStreamBubbleModel() {
1401 // In general, bubble models might not inherit from the media bubble model. 1401 // In general, bubble models might not inherit from the media bubble model.
1402 return nullptr; 1402 return nullptr;
1403 } 1403 }
1404 1404
1405 ContentSettingSubresourceFilterBubbleModel* 1405 ContentSettingSubresourceFilterBubbleModel*
1406 ContentSettingBubbleModel::AsSubresourceFilterBubbleModel() { 1406 ContentSettingBubbleModel::AsSubresourceFilterBubbleModel() {
1407 return nullptr; 1407 return nullptr;
1408 } 1408 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698