Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2220573002: [turbofan] Add NumberOperationHint for speculative number operations. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add NumberOperationHint for speculative number operations. Introduce a dedicated NumberOperationHint enum that represents the feedback we can use for speculative number operations. BUG=v8:4930 Committed: https://crrev.com/2c8b51448c50710c146082efdf9a5744ba9a32fe Cr-Commit-Position: refs/heads/master@{#38411}

Patch Set 1 #

Patch Set 2 : Recement tests. #

Patch Set 3 : REBASE #

Patch Set 4 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+586 lines, -386 lines) Patch
M src/compiler/js-typed-lowering.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 8 chunks +145 lines, -142 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 18 chunks +35 lines, -39 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 2 3 3 chunks +27 lines, -20 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 2 5 chunks +56 lines, -52 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 8 chunks +296 lines, -106 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 4 chunks +18 lines, -19 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
Benedikt Meurer
Hey Jaro, Here's the NumberOperationHint change. Please take a look. Thanks, Benedikt
4 years, 4 months ago (2016-08-05 14:37:58 UTC) #6
Jarin
lgtm
4 years, 4 months ago (2016-08-08 06:04:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220573002/60001
4 years, 4 months ago (2016-08-08 06:05:22 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-08 06:07:30 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 06:10:53 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2c8b51448c50710c146082efdf9a5744ba9a32fe
Cr-Commit-Position: refs/heads/master@{#38411}

Powered by Google App Engine
This is Rietveld 408576698