[turbofan] Add NumberOperationHint for speculative number operations.

test/unittests/compiler/js-typed-lowering-unittest.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-factory.h"
 #include "src/compiler/access-builder.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/js-operator.h"
 #include "src/compiler/js-typed-lowering.h"
 #include "src/compiler/machine-operator.h"
@@ skipping 398 matching lines @@
       graph()->NewNode(javascript()->StrictEqual(CompareOperationHints::Any()),
                        lhs, rhs, context));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(), IsReferenceEqual(Type::Unique(), lhs, rhs));
 }
 
 
 // -----------------------------------------------------------------------------
 // JSShiftLeft
 
-
 TEST_F(JSTypedLoweringTest, JSShiftLeftWithSigned32AndConstant) {
   BinaryOperationHints const hints = BinaryOperationHints::Any();
   Node* const lhs = Parameter(Type::Signed32());
   Node* const context = UndefinedConstant();
   Node* const effect = graph()->start();
   Node* const control = graph()->start();
   TRACED_FORRANGE(double, rhs, 0, 31) {
     Reduction r = Reduce(graph()->NewNode(javascript()->ShiftLeft(hints), lhs,
                                           NumberConstant(rhs), context,
                                           EmptyFrameState(), effect, control));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(),
                 IsNumberShiftLeft(lhs, IsNumberConstant(BitEq(rhs))));
   }
 }
 
-
 TEST_F(JSTypedLoweringTest, JSShiftLeftWithSigned32AndUnsigned32) {
   BinaryOperationHints const hints = BinaryOperationHints::Any();
   Node* const lhs = Parameter(Type::Signed32());
   Node* const rhs = Parameter(Type::Unsigned32());
   Node* const context = UndefinedConstant();
   Node* const effect = graph()->start();
   Node* const control = graph()->start();
   Reduction r =
       Reduce(graph()->NewNode(javascript()->ShiftLeft(hints), lhs, rhs, context,
                               EmptyFrameState(), effect, control));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(), IsNumberShiftLeft(lhs, rhs));
 }
 
-TEST_F(JSTypedLoweringTest, JSShiftLeftWithTypeFeedback) {
-  BinaryOperationHints::Hint const feedback_types[] = {
-      BinaryOperationHints::kSignedSmall,
-      BinaryOperationHints::kNumberOrOddball};
-  for (BinaryOperationHints::Hint feedback : feedback_types) {
-    BinaryOperationHints const hints(feedback, feedback, feedback);
-    Node* lhs = Parameter(Type::Number(), 2);
-    Node* rhs = Parameter(Type::Number(), 3);
-    Node* effect = graph()->start();
-    Node* control = graph()->start();
-    Reduction r = Reduce(graph()->NewNode(javascript()->ShiftLeft(hints), lhs,
-                                          rhs, UndefinedConstant(),
-                                          EmptyFrameState(), effect, control));
-    ASSERT_TRUE(r.Changed());
-    EXPECT_THAT(r.replacement(), IsSpeculativeNumberShiftLeft(
-                                     feedback, lhs, rhs, effect, control));
-  }
+TEST_F(JSTypedLoweringTest, JSShiftLeftWithSignedSmallHint) {
+  BinaryOperationHints const hints(BinaryOperationHints::kSignedSmall,
+                                   BinaryOperationHints::kSignedSmall,
+                                   BinaryOperationHints::kSignedSmall);
+  Node* lhs = Parameter(Type::Number(), 2);
+  Node* rhs = Parameter(Type::Number(), 3);
+  Node* effect = graph()->start();
+  Node* control = graph()->start();
+  Reduction r = Reduce(graph()->NewNode(javascript()->ShiftLeft(hints), lhs,
+                                        rhs, UndefinedConstant(),
+                                        EmptyFrameState(), effect, control));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(),
+              IsSpeculativeNumberShiftLeft(NumberOperationHint::kSignedSmall,
+                                           lhs, rhs, effect, control));
+}
+
+TEST_F(JSTypedLoweringTest, JSShiftLeftWithSigned32Hint) {
+  BinaryOperationHints const hints(BinaryOperationHints::kSigned32,
+                                   BinaryOperationHints::kSigned32,
+                                   BinaryOperationHints::kSigned32);
+  Node* lhs = Parameter(Type::Number(), 2);
+  Node* rhs = Parameter(Type::Number(), 3);
+  Node* effect = graph()->start();
+  Node* control = graph()->start();
+  Reduction r = Reduce(graph()->NewNode(javascript()->ShiftLeft(hints), lhs,
+                                        rhs, UndefinedConstant(),
+                                        EmptyFrameState(), effect, control));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(),
+              IsSpeculativeNumberShiftLeft(NumberOperationHint::kSigned32, lhs,
+                                           rhs, effect, control));
+}
+
+TEST_F(JSTypedLoweringTest, JSShiftLeftWithNumberOrOddballHint) {
+  BinaryOperationHints const hints(BinaryOperationHints::kNumberOrOddball,
+                                   BinaryOperationHints::kNumberOrOddball,
+                                   BinaryOperationHints::kNumberOrOddball);
+  Node* lhs = Parameter(Type::Number(), 2);
+  Node* rhs = Parameter(Type::Number(), 3);
+  Node* effect = graph()->start();
+  Node* control = graph()->start();
+  Reduction r = Reduce(graph()->NewNode(javascript()->ShiftLeft(hints), lhs,
+                                        rhs, UndefinedConstant(),
+                                        EmptyFrameState(), effect, control));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(), IsSpeculativeNumberShiftLeft(
+                                   NumberOperationHint::kNumberOrOddball, lhs,
+                                   rhs, effect, control));
 }
 
 // -----------------------------------------------------------------------------
 // JSShiftRight
 
 
 TEST_F(JSTypedLoweringTest, JSShiftRightWithSigned32AndConstant) {
   BinaryOperationHints const hints = BinaryOperationHints::Any();
   Node* const lhs = Parameter(Type::Signed32());
   Node* const context = UndefinedConstant();
@@ skipping 17 matching lines @@
   Node* const context = UndefinedConstant();
   Node* const effect = graph()->start();
   Node* const control = graph()->start();
   Reduction r =
       Reduce(graph()->NewNode(javascript()->ShiftRight(hints), lhs, rhs,
                               context, EmptyFrameState(), effect, control));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(), IsNumberShiftRight(lhs, rhs));
 }
 
-TEST_F(JSTypedLoweringTest, JSShiftRightWithTypeFeedback) {
-  BinaryOperationHints::Hint const feedback_types[] = {
-      BinaryOperationHints::kSignedSmall,
-      BinaryOperationHints::kNumberOrOddball};
-  for (BinaryOperationHints::Hint feedback : feedback_types) {
-    BinaryOperationHints const hints(feedback, feedback, feedback);
-    Node* lhs = Parameter(Type::Number(), 2);
-    Node* rhs = Parameter(Type::Number(), 3);
-    Node* effect = graph()->start();
-    Node* control = graph()->start();
-    Reduction r = Reduce(graph()->NewNode(javascript()->ShiftRight(hints), lhs,
-                                          rhs, UndefinedConstant(),
-                                          EmptyFrameState(), effect, control));
-    ASSERT_TRUE(r.Changed());
-    EXPECT_THAT(r.replacement(), IsSpeculativeNumberShiftRight(
-                                     feedback, lhs, rhs, effect, control));
-  }
+TEST_F(JSTypedLoweringTest, JSShiftRightWithSignedSmallHint) {
+  BinaryOperationHints const hints(BinaryOperationHints::kSignedSmall,
+                                   BinaryOperationHints::kSignedSmall,
+                                   BinaryOperationHints::kSignedSmall);
+  Node* lhs = Parameter(Type::Number(), 2);
+  Node* rhs = Parameter(Type::Number(), 3);
+  Node* effect = graph()->start();
+  Node* control = graph()->start();
+  Reduction r = Reduce(graph()->NewNode(javascript()->ShiftRight(hints), lhs,
+                                        rhs, UndefinedConstant(),
+                                        EmptyFrameState(), effect, control));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(),
+              IsSpeculativeNumberShiftRight(NumberOperationHint::kSignedSmall,
+                                            lhs, rhs, effect, control));
+}
+
+TEST_F(JSTypedLoweringTest, JSShiftRightWithSigned32Hint) {
+  BinaryOperationHints const hints(BinaryOperationHints::kSigned32,
+                                   BinaryOperationHints::kSigned32,
+                                   BinaryOperationHints::kSigned32);
+  Node* lhs = Parameter(Type::Number(), 2);
+  Node* rhs = Parameter(Type::Number(), 3);
+  Node* effect = graph()->start();
+  Node* control = graph()->start();
+  Reduction r = Reduce(graph()->NewNode(javascript()->ShiftRight(hints), lhs,
+                                        rhs, UndefinedConstant(),
+                                        EmptyFrameState(), effect, control));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(),
+              IsSpeculativeNumberShiftRight(NumberOperationHint::kSigned32, lhs,
+                                            rhs, effect, control));
+}
+
+TEST_F(JSTypedLoweringTest, JSShiftRightWithNumberOrOddballHint) {
+  BinaryOperationHints const hints(BinaryOperationHints::kNumberOrOddball,
+                                   BinaryOperationHints::kNumberOrOddball,
+                                   BinaryOperationHints::kNumberOrOddball);
+  Node* lhs = Parameter(Type::Number(), 2);
+  Node* rhs = Parameter(Type::Number(), 3);
+  Node* effect = graph()->start();
+  Node* control = graph()->start();
+  Reduction r = Reduce(graph()->NewNode(javascript()->ShiftRight(hints), lhs,
+                                        rhs, UndefinedConstant(),
+                                        EmptyFrameState(), effect, control));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(), IsSpeculativeNumberShiftRight(
+                                   NumberOperationHint::kNumberOrOddball, lhs,
+                                   rhs, effect, control));
 }
 
 // -----------------------------------------------------------------------------
 // JSShiftRightLogical
 
 
 TEST_F(JSTypedLoweringTest,
                    JSShiftRightLogicalWithUnsigned32AndConstant) {
   BinaryOperationHints const hints = BinaryOperationHints::Any();
   Node* const lhs = Parameter(Type::Unsigned32());
@@ skipping 18 matching lines @@
   Node* const context = UndefinedConstant();
   Node* const effect = graph()->start();
   Node* const control = graph()->start();
   Reduction r =
       Reduce(graph()->NewNode(javascript()->ShiftRightLogical(hints), lhs, rhs,
                               context, EmptyFrameState(), effect, control));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(), IsNumberShiftRightLogical(lhs, rhs));
 }
 
-TEST_F(JSTypedLoweringTest, JSShiftRightLogicalWithTypeFeedback) {
-  BinaryOperationHints::Hint const feedback_types[] = {
-      BinaryOperationHints::kSignedSmall,
-      BinaryOperationHints::kNumberOrOddball};
-  for (BinaryOperationHints::Hint feedback : feedback_types) {
-    BinaryOperationHints const hints(feedback, feedback, feedback);
-    Node* lhs = Parameter(Type::Number(), 2);
-    Node* rhs = Parameter(Type::Number(), 3);
-    Node* effect = graph()->start();
-    Node* control = graph()->start();
-    Reduction r = Reduce(graph()->NewNode(
-        javascript()->ShiftRightLogical(hints), lhs, rhs, UndefinedConstant(),
-        EmptyFrameState(), effect, control));
-    ASSERT_TRUE(r.Changed());
-    EXPECT_THAT(r.replacement(), IsSpeculativeNumberShiftRightLogical(
-                                     feedback, lhs, rhs, effect, control));
-  }
+TEST_F(JSTypedLoweringTest, JSShiftRightLogicalWithSignedSmallHint) {
+  BinaryOperationHints const hints(BinaryOperationHints::kSignedSmall,
+                                   BinaryOperationHints::kSignedSmall,
+                                   BinaryOperationHints::kSignedSmall);
+  Node* lhs = Parameter(Type::Number(), 2);
+  Node* rhs = Parameter(Type::Number(), 3);
+  Node* effect = graph()->start();
+  Node* control = graph()->start();
+  Reduction r = Reduce(graph()->NewNode(javascript()->ShiftRightLogical(hints),
+                                        lhs, rhs, UndefinedConstant(),
+                                        EmptyFrameState(), effect, control));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(), IsSpeculativeNumberShiftRightLogical(
+                                   NumberOperationHint::kSignedSmall, lhs, rhs,
+                                   effect, control));
+}
+
+TEST_F(JSTypedLoweringTest, JSShiftRightLogicalWithSigned32Hint) {
+  BinaryOperationHints const hints(BinaryOperationHints::kSigned32,
+                                   BinaryOperationHints::kSigned32,
+                                   BinaryOperationHints::kSigned32);
+  Node* lhs = Parameter(Type::Number(), 2);
+  Node* rhs = Parameter(Type::Number(), 3);
+  Node* effect = graph()->start();
+  Node* control = graph()->start();
+  Reduction r = Reduce(graph()->NewNode(javascript()->ShiftRightLogical(hints),
+                                        lhs, rhs, UndefinedConstant(),
+                                        EmptyFrameState(), effect, control));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(),
+              IsSpeculativeNumberShiftRightLogical(
+                  NumberOperationHint::kSigned32, lhs, rhs, effect, control));
+}
+
+TEST_F(JSTypedLoweringTest, JSShiftRightLogicalWithNumberOrOddballHint) {
+  BinaryOperationHints const hints(BinaryOperationHints::kNumberOrOddball,
+                                   BinaryOperationHints::kNumberOrOddball,
+                                   BinaryOperationHints::kNumberOrOddball);
+  Node* lhs = Parameter(Type::Number(), 2);
+  Node* rhs = Parameter(Type::Number(), 3);
+  Node* effect = graph()->start();
+  Node* control = graph()->start();
+  Reduction r = Reduce(graph()->NewNode(javascript()->ShiftRightLogical(hints),
+                                        lhs, rhs, UndefinedConstant(),
+                                        EmptyFrameState(), effect, control));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(), IsSpeculativeNumberShiftRightLogical(
+                                   NumberOperationHint::kNumberOrOddball, lhs,
+                                   rhs, effect, control));
 }
 
 // -----------------------------------------------------------------------------
 // JSLoadContext
 
 
 TEST_F(JSTypedLoweringTest, JSLoadContext) {
   Node* const context = Parameter(Type::Any());
   Node* const effect = graph()->start();
   static bool kBooleans[] = {false, true};
@@ skipping 325 matching lines @@
   Node* lhs = Parameter(Type::Number(), 0);
   Node* rhs = Parameter(Type::Number(), 1);
   Node* context = Parameter(Type::Any(), 2);
   Node* frame_state = EmptyFrameState();
   Node* effect = graph()->start();
   Node* control = graph()->start();
   Reduction r = Reduce(graph()->NewNode(javascript()->Add(hints), lhs, rhs,
                                         context, frame_state, effect, control));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(),
-              IsSpeculativeNumberAdd(BinaryOperationHints::kSignedSmall, lhs,
+              IsSpeculativeNumberAdd(NumberOperationHint::kSignedSmall, lhs,
                                      rhs, effect, control));
 }
 
 // -----------------------------------------------------------------------------
 // JSSubtract
 
 TEST_F(JSTypedLoweringTest, JSSubtractSmis) {
   BinaryOperationHints const hints(BinaryOperationHints::kSignedSmall,
                                    BinaryOperationHints::kSignedSmall,
                                    BinaryOperationHints::kSignedSmall);
   Node* lhs = Parameter(Type::Number(), 0);
   Node* rhs = Parameter(Type::Number(), 1);
   Node* context = Parameter(Type::Any(), 2);
   Node* frame_state = EmptyFrameState();
   Node* effect = graph()->start();
   Node* control = graph()->start();
   Reduction r = Reduce(graph()->NewNode(javascript()->Subtract(hints), lhs, rhs,
                                         context, frame_state, effect, control));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(),
-              IsSpeculativeNumberSubtract(BinaryOperationHints::kSignedSmall,
+              IsSpeculativeNumberSubtract(NumberOperationHint::kSignedSmall,
                                           lhs, rhs, effect, control));
 }
 
 // -----------------------------------------------------------------------------
 // JSInstanceOf
 // Test that instanceOf is reduced if and only if the right-hand side is a
 // function constant. Functional correctness is ensured elsewhere.
 
 TEST_F(JSTypedLoweringTest, JSInstanceOfSpecializationWithoutSmiCheck) {
   Node* const context = Parameter(Type::Any());
@@ skipping 48 matching lines @@
   Node* dummy = graph()->NewNode(javascript()->ToObject(), instanceOf, context,
                                  frame_state, effect, control);
   Reduction r = Reduce(instanceOf);
   ASSERT_FALSE(r.Changed());
   ASSERT_EQ(instanceOf, dummy->InputAt(0));
 }
 
 // -----------------------------------------------------------------------------
 // JSBitwiseAnd
 
-TEST_F(JSTypedLoweringTest, JSBitwiseAndWithTypeFeedback) {
-  BinaryOperationHints::Hint const feedback_types[] = {
-      BinaryOperationHints::kSignedSmall,
-      BinaryOperationHints::kNumberOrOddball};
-  for (BinaryOperationHints::Hint feedback : feedback_types) {
-    BinaryOperationHints const hints(feedback, feedback, feedback);
-    Node* lhs = Parameter(Type::Number(), 2);
-    Node* rhs = Parameter(Type::Number(), 3);
-    Node* effect = graph()->start();
-    Node* control = graph()->start();
-    Reduction r = Reduce(graph()->NewNode(javascript()->BitwiseAnd(hints), lhs,
-                                          rhs, UndefinedConstant(),
-                                          EmptyFrameState(), effect, control));
-    ASSERT_TRUE(r.Changed());
-    EXPECT_THAT(r.replacement(), IsSpeculativeNumberBitwiseAnd(
-                                     feedback, lhs, rhs, effect, control));
-  }
+TEST_F(JSTypedLoweringTest, JSBitwiseAndWithSignedSmallHint) {
+  BinaryOperationHints const hints(BinaryOperationHints::kSignedSmall,
+                                   BinaryOperationHints::kSignedSmall,
+                                   BinaryOperationHints::kSignedSmall);
+  Node* lhs = Parameter(Type::Number(), 2);
+  Node* rhs = Parameter(Type::Number(), 3);
+  Node* effect = graph()->start();
+  Node* control = graph()->start();
+  Reduction r = Reduce(graph()->NewNode(javascript()->BitwiseAnd(hints), lhs,
+                                        rhs, UndefinedConstant(),
+                                        EmptyFrameState(), effect, control));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(),
+              IsSpeculativeNumberBitwiseAnd(NumberOperationHint::kSignedSmall,
+                                            lhs, rhs, effect, control));
+}
+
+TEST_F(JSTypedLoweringTest, JSBitwiseAndWithSigned32Hint) {
+  BinaryOperationHints const hints(BinaryOperationHints::kSigned32,
+                                   BinaryOperationHints::kSigned32,
+                                   BinaryOperationHints::kSigned32);
+  Node* lhs = Parameter(Type::Number(), 2);
+  Node* rhs = Parameter(Type::Number(), 3);
+  Node* effect = graph()->start();
+  Node* control = graph()->start();
+  Reduction r = Reduce(graph()->NewNode(javascript()->BitwiseAnd(hints), lhs,
+                                        rhs, UndefinedConstant(),
+                                        EmptyFrameState(), effect, control));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(),
+              IsSpeculativeNumberBitwiseAnd(NumberOperationHint::kSigned32, lhs,
+                                            rhs, effect, control));
+}
+
+TEST_F(JSTypedLoweringTest, JSBitwiseAndWithNumberOrOddballHint) {
+  BinaryOperationHints const hints(BinaryOperationHints::kNumberOrOddball,
+                                   BinaryOperationHints::kNumberOrOddball,
+                                   BinaryOperationHints::kNumberOrOddball);
+  Node* lhs = Parameter(Type::Number(), 2);
+  Node* rhs = Parameter(Type::Number(), 3);
+  Node* effect = graph()->start();
+  Node* control = graph()->start();
+  Reduction r = Reduce(graph()->NewNode(javascript()->BitwiseAnd(hints), lhs,
+                                        rhs, UndefinedConstant(),
+                                        EmptyFrameState(), effect, control));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(), IsSpeculativeNumberBitwiseAnd(
+                                   NumberOperationHint::kNumberOrOddball, lhs,
+                                   rhs, effect, control));
 }
 
 // -----------------------------------------------------------------------------
 // JSBitwiseOr
 
-TEST_F(JSTypedLoweringTest, JSBitwiseOrWithTypeFeedback) {
-  BinaryOperationHints::Hint const feedback_types[] = {
-      BinaryOperationHints::kSignedSmall,
-      BinaryOperationHints::kNumberOrOddball};
-  for (BinaryOperationHints::Hint feedback : feedback_types) {
-    BinaryOperationHints const hints(feedback, feedback, feedback);
-    Node* lhs = Parameter(Type::Number(), 2);
-    Node* rhs = Parameter(Type::Number(), 3);
-    Node* effect = graph()->start();
-    Node* control = graph()->start();
-    Reduction r = Reduce(graph()->NewNode(javascript()->BitwiseOr(hints), lhs,
-                                          rhs, UndefinedConstant(),
-                                          EmptyFrameState(), effect, control));
-    ASSERT_TRUE(r.Changed());
-    EXPECT_THAT(r.replacement(), IsSpeculativeNumberBitwiseOr(
-                                     feedback, lhs, rhs, effect, control));
-  }
+TEST_F(JSTypedLoweringTest, JSBitwiseOrWithSignedSmallHint) {
+  BinaryOperationHints const hints(BinaryOperationHints::kSignedSmall,
+                                   BinaryOperationHints::kSignedSmall,
+                                   BinaryOperationHints::kSignedSmall);
+  Node* lhs = Parameter(Type::Number(), 2);
+  Node* rhs = Parameter(Type::Number(), 3);
+  Node* effect = graph()->start();
+  Node* control = graph()->start();
+  Reduction r = Reduce(graph()->NewNode(javascript()->BitwiseOr(hints), lhs,
+                                        rhs, UndefinedConstant(),
+                                        EmptyFrameState(), effect, control));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(),
+              IsSpeculativeNumberBitwiseOr(NumberOperationHint::kSignedSmall,
+                                           lhs, rhs, effect, control));
+}
+
+TEST_F(JSTypedLoweringTest, JSBitwiseOrWithSigned32Hint) {
+  BinaryOperationHints const hints(BinaryOperationHints::kSigned32,
+                                   BinaryOperationHints::kSigned32,
+                                   BinaryOperationHints::kSigned32);
+  Node* lhs = Parameter(Type::Number(), 2);
+  Node* rhs = Parameter(Type::Number(), 3);
+  Node* effect = graph()->start();
+  Node* control = graph()->start();
+  Reduction r = Reduce(graph()->NewNode(javascript()->BitwiseOr(hints), lhs,
+                                        rhs, UndefinedConstant(),
+                                        EmptyFrameState(), effect, control));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(),
+              IsSpeculativeNumberBitwiseOr(NumberOperationHint::kSigned32, lhs,
+                                           rhs, effect, control));
+}
+
+TEST_F(JSTypedLoweringTest, JSBitwiseOrWithNumberOrOddballHint) {
+  BinaryOperationHints const hints(BinaryOperationHints::kNumberOrOddball,
+                                   BinaryOperationHints::kNumberOrOddball,
+                                   BinaryOperationHints::kNumberOrOddball);
+  Node* lhs = Parameter(Type::Number(), 2);
+  Node* rhs = Parameter(Type::Number(), 3);
+  Node* effect = graph()->start();
+  Node* control = graph()->start();
+  Reduction r = Reduce(graph()->NewNode(javascript()->BitwiseOr(hints), lhs,
+                                        rhs, UndefinedConstant(),
+                                        EmptyFrameState(), effect, control));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(), IsSpeculativeNumberBitwiseOr(
+                                   NumberOperationHint::kNumberOrOddball, lhs,
+                                   rhs, effect, control));
 }
 
 // -----------------------------------------------------------------------------
 // JSBitwiseXor
 
-TEST_F(JSTypedLoweringTest, JSBitwiseXorWithTypeFeedback) {
-  BinaryOperationHints::Hint const feedback_types[] = {
-      BinaryOperationHints::kSignedSmall,
-      BinaryOperationHints::kNumberOrOddball};
-  for (BinaryOperationHints::Hint feedback : feedback_types) {
-    BinaryOperationHints const hints(feedback, feedback, feedback);
-    Node* lhs = Parameter(Type::Number(), 2);
-    Node* rhs = Parameter(Type::Number(), 3);
-    Node* effect = graph()->start();
-    Node* control = graph()->start();
-    Reduction r = Reduce(graph()->NewNode(javascript()->BitwiseXor(hints), lhs,
-                                          rhs, UndefinedConstant(),
-                                          EmptyFrameState(), effect, control));
-    ASSERT_TRUE(r.Changed());
-    EXPECT_THAT(r.replacement(), IsSpeculativeNumberBitwiseXor(
-                                     feedback, lhs, rhs, effect, control));
-  }
+TEST_F(JSTypedLoweringTest, JSBitwiseXorWithSignedSmallHint) {
+  BinaryOperationHints const hints(BinaryOperationHints::kSignedSmall,
+                                   BinaryOperationHints::kSignedSmall,
+                                   BinaryOperationHints::kSignedSmall);
+  Node* lhs = Parameter(Type::Number(), 2);
+  Node* rhs = Parameter(Type::Number(), 3);
+  Node* effect = graph()->start();
+  Node* control = graph()->start();
+  Reduction r = Reduce(graph()->NewNode(javascript()->BitwiseXor(hints), lhs,
+                                        rhs, UndefinedConstant(),
+                                        EmptyFrameState(), effect, control));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(),
+              IsSpeculativeNumberBitwiseXor(NumberOperationHint::kSignedSmall,
+                                            lhs, rhs, effect, control));
+}
+
+TEST_F(JSTypedLoweringTest, JSBitwiseXorWithSigned32Hint) {
+  BinaryOperationHints const hints(BinaryOperationHints::kSigned32,
+                                   BinaryOperationHints::kSigned32,
+                                   BinaryOperationHints::kSigned32);
+  Node* lhs = Parameter(Type::Number(), 2);
+  Node* rhs = Parameter(Type::Number(), 3);
+  Node* effect = graph()->start();
+  Node* control = graph()->start();
+  Reduction r = Reduce(graph()->NewNode(javascript()->BitwiseXor(hints), lhs,
+                                        rhs, UndefinedConstant(),
+                                        EmptyFrameState(), effect, control));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(),
+              IsSpeculativeNumberBitwiseXor(NumberOperationHint::kSigned32, lhs,
+                                            rhs, effect, control));
+}
+
+TEST_F(JSTypedLoweringTest, JSBitwiseXorWithNumberOrOddballHint) {
+  BinaryOperationHints const hints(BinaryOperationHints::kNumberOrOddball,
+                                   BinaryOperationHints::kNumberOrOddball,
+                                   BinaryOperationHints::kNumberOrOddball);
+  Node* lhs = Parameter(Type::Number(), 2);
+  Node* rhs = Parameter(Type::Number(), 3);
+  Node* effect = graph()->start();
+  Node* control = graph()->start();
+  Reduction r = Reduce(graph()->NewNode(javascript()->BitwiseXor(hints), lhs,
+                                        rhs, UndefinedConstant(),
+                                        EmptyFrameState(), effect, control));
+  ASSERT_TRUE(r.Changed());
+  EXPECT_THAT(r.replacement(), IsSpeculativeNumberBitwiseXor(
+                                   NumberOperationHint::kNumberOrOddball, lhs,
+                                   rhs, effect, control));
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8