Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2220543002: Make Resource::resourceBuffer() to return PassRefPtr<const SharedBuffer> (Closed)

Created:
4 years, 4 months ago by hiroshige
Modified:
4 years, 3 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dominicc+watchlist_chromium.org, gavinp+loader_chromium.org, Nate Chapin, kozyatinskiy+blink_chromium.org, loading-reviews+fetch_chromium.org, loading-reviews_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@WTF_UseIsConvertibleInEnsure
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Resource::resourceBuffer() to return PassRefPtr<const SharedBuffer> To make clear that the SharedBuffer() returned by resourceBuffer() is not modified outside Resource class. BUG= Committed: https://crrev.com/19ff459a950a6d5ece873eeb33db5a22fb326dd3 Cr-Commit-Position: refs/heads/master@{#419130}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase (no ifdef) #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -30 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameSerializer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameSerializer.cpp View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.h View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/parser/SharedBufferReader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xml/parser/SharedBufferReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/SerializedResource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/SharedBufferChunkReader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/SharedBufferChunkReader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLParser.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 32 (19 generated)
hiroshige
PTAL. (mkwst@ as a bindings/core/platform OWNER)
4 years, 3 months ago (2016-09-01 10:38:14 UTC) #2
hajimehoshi
lgtm
4 years, 3 months ago (2016-09-01 11:19:53 UTC) #3
haraken
LGTM
4 years, 3 months ago (2016-09-01 17:43:23 UTC) #8
Mike West
LGTM (sorry for the delay, I'm underwater these days...)
4 years, 3 months ago (2016-09-05 06:53:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220543002/80001
4 years, 3 months ago (2016-09-15 03:04:26 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/157417) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-15 03:07:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220543002/100001
4 years, 3 months ago (2016-09-15 06:28:21 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/293606)
4 years, 3 months ago (2016-09-15 09:43:46 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220543002/100001
4 years, 3 months ago (2016-09-15 09:46:52 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/293733)
4 years, 3 months ago (2016-09-15 13:23:37 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220543002/100001
4 years, 3 months ago (2016-09-16 07:11:32 UTC) #29
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 3 months ago (2016-09-16 08:32:30 UTC) #30
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 08:34:47 UTC) #32
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/19ff459a950a6d5ece873eeb33db5a22fb326dd3
Cr-Commit-Position: refs/heads/master@{#419130}

Powered by Google App Engine
This is Rietveld 408576698