third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp - Issue 2220543002: Make Resource::resourceBuffer() to return PassRefPtr<const SharedBuffer>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

Issue 2220543002: Make Resource::resourceBuffer() to return PassRefPtr<const SharedBuffer> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WTF_UseIsConvertibleInEnsure

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp ('k') | third_party/WebKit/Source/core/xml/parser/SharedBufferReader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

diff --git a/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp b/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

index 4fc8a9d5857946f36a8afa3f3ba51b291acc2051..7e81480d9b422b07626ee698f815a64c1945998a 100644

--- a/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

+++ b/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

@@ -117,7 +117,7 @@ static xmlDocPtr docLoaderFunc(

// We don't specify an encoding here. Neither Gecko nor WinIE respects

// the encoding specified in the HTTP headers.

- RefPtr<SharedBuffer> data = resource->resourceBuffer();

+ RefPtr<const SharedBuffer> data = resource->resourceBuffer();

xmlDocPtr doc = data ? xmlReadMemory(data->data(), data->size(), (const char*)uri, 0, options) : nullptr;

xmlSetStructuredErrorFunc(0, 0);