Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2220483003: [x64] Zero/sign-extend loads to 64-bit registers. (Closed)

Created:
4 years, 4 months ago by epertoso
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Zero/sign-extend loads to 64-bit registers. Before this change we would first load an 8/16/32-bit value from memory into a 32-bit register, then zero/sign-extend from that register to a 64-bit one. Now we replace that pattern with a single movsx/movzx. Ported from http://crrev.com/2183923003 R=bmeurer@chromium.org Committed: https://crrev.com/4abecb7a27bd5fa073d0ff5fadb0c2bb248ef9f4 Committed: https://crrev.com/b79d7b0486779cea1af6ec17b2fe468e6973fd38 Cr-Original-Commit-Position: refs/heads/master@{#38388} Cr-Commit-Position: refs/heads/master@{#38428}

Patch Set 1 #

Patch Set 2 : Removed a couple of wrong assertions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -2 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-scheduler-x64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 1 chunk +30 lines, -1 line 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M test/unittests/compiler/x64/instruction-selector-x64-unittest.cc View 2 chunks +35 lines, -1 line 0 comments Download

Messages

Total messages: 27 (17 generated)
epertoso
4 years, 4 months ago (2016-08-05 13:06:25 UTC) #5
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-08-05 13:27:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220483003/20001
4 years, 4 months ago (2016-08-05 13:32:13 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-05 13:33:55 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4abecb7a27bd5fa073d0ff5fadb0c2bb248ef9f4 Cr-Commit-Position: refs/heads/master@{#38388}
4 years, 4 months ago (2016-08-05 13:34:32 UTC) #14
Michael Achenbach
A revert of this CL (patchset #1 id:20001) has been created in https://codereview.chromium.org/2221473002/ by machenbach@chromium.org. ...
4 years, 4 months ago (2016-08-05 14:27:08 UTC) #15
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-08-08 09:30:15 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220483003/40001
4 years, 4 months ago (2016-08-08 09:57:24 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-08 09:59:25 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 10:00:53 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b79d7b0486779cea1af6ec17b2fe468e6973fd38
Cr-Commit-Position: refs/heads/master@{#38428}

Powered by Google App Engine
This is Rietveld 408576698