src/compiler/x64/instruction-scheduler-x64.cc - Issue 2220483003: [x64] Zero/sign-extend loads to 64-bit registers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x64/instruction-scheduler-x64.cc

Issue 2220483003: [x64] Zero/sign-extend loads to 64-bit registers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Removed a couple of wrong assertions. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/x64/instruction-scheduler-x64.cc

diff --git a/src/compiler/x64/instruction-scheduler-x64.cc b/src/compiler/x64/instruction-scheduler-x64.cc

index f4965c7fc0c9a310758bfb603360910b61355c60..c6f95f0f9f0f974bdc4bc844c7f484851a346581 100644

--- a/src/compiler/x64/instruction-scheduler-x64.cc

+++ b/src/compiler/x64/instruction-scheduler-x64.cc

@@ -131,8 +131,12 @@ int InstructionScheduler::GetTargetInstructionFlags(

case kX64Movsxbl:

case kX64Movzxbl:

+ case kX64Movsxbq:

+ case kX64Movzxbq:

case kX64Movsxwl:

case kX64Movzxwl:

+ case kX64Movsxwq:

+ case kX64Movzxwq:

case kX64Movsxlq:

DCHECK(instr->InputCount() >= 1);

return instr->InputAt(0)->IsRegister() ? kNoOpcodeFlags