Hook up compiler dispatcher jobs to lazy parser.

Hook up compiler dispatcher jobs to lazy parser.

The lazy parser actually parses eagerly. It's called lazy because it
parses functions that were previously lazy parsed. D'uh.

BUG=v8:5215
R=marja@chromium.org

Committed: https://crrev.com/255cc15f98507e2bba49574f4dc38c74deb0ca2c
Cr-Commit-Position: refs/heads/master@{#38375}

[jochen (gone - plz use gerrit), 2016-08-05 07:37:36]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 07:37:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 07:56:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 07:56:48]

Dry run: This issue passed the CQ dry run.

[marja, 2016-08-05 09:43:05]

https://codereview.chromium.org/2220463002/diff/1/src/compiler-dispatcher/com...
File src/compiler-dispatcher/compiler-dispatcher-job.cc (left):

https://codereview.chromium.org/2220463002/diff/1/src/compiler-dispatcher/com...
src/compiler-dispatcher/compiler-dispatcher-job.cc:69:
parse_info_->set_hash_seed(isolate_->heap()->HashSeed());
Why don't you need the hash seed any more?

https://codereview.chromium.org/2220463002/diff/1/src/compiler-dispatcher/com...
File src/compiler-dispatcher/compiler-dispatcher-job.cc (right):

https://codereview.chromium.org/2220463002/diff/1/src/compiler-dispatcher/com...
src/compiler-dispatcher/compiler-dispatcher-job.cc:71: parse_info_->set_lazy();
Why? Don't we need to at least check some FLAG_s to find out if lazy parsing is
allowed?

https://codereview.chromium.org/2220463002/diff/1/src/compiler-dispatcher/com...
src/compiler-dispatcher/compiler-dispatcher-job.cc:138: }
Why is this good - the HandleScope goes out of Scope but FunctionLiteral stored
the Handle... Why is that working?

[jochen (gone - plz use gerrit), 2016-08-05 11:20:08]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 11:20:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-08-05 11:20:16]

https://codereview.chromium.org/2220463002/diff/1/src/compiler-dispatcher/com...
File src/compiler-dispatcher/compiler-dispatcher-job.cc (left):

https://codereview.chromium.org/2220463002/diff/1/src/compiler-dispatcher/com...
src/compiler-dispatcher/compiler-dispatcher-job.cc:69:
parse_info_->set_hash_seed(isolate_->heap()->HashSeed());
On 2016/08/05 at 09:43:05, marja wrote:
> Why don't you need the hash seed any more?

Oops, didn't want to delete that

https://codereview.chromium.org/2220463002/diff/1/src/compiler-dispatcher/com...
File src/compiler-dispatcher/compiler-dispatcher-job.cc (right):

https://codereview.chromium.org/2220463002/diff/1/src/compiler-dispatcher/com...
src/compiler-dispatcher/compiler-dispatcher-job.cc:71: parse_info_->set_lazy();
On 2016/08/05 at 09:43:05, marja wrote:
> Why? Don't we need to at least check some FLAG_s to find out if lazy parsing
is allowed?

In the spirit of ParseLazy this flag means that the function was compiled lazily
before, and now should be eagerly compiled :-/

https://codereview.chromium.org/2220463002/diff/1/src/compiler-dispatcher/com...
src/compiler-dispatcher/compiler-dispatcher-job.cc:138: }
On 2016/08/05 at 09:43:05, marja wrote:
> Why is this good - the HandleScope goes out of Scope but FunctionLiteral
stored the Handle... Why is that working?

True. I'll just do that when preparing the compilation, because I'll need a
DeferredHandleScope then anyways

[commit-bot: I haz the power, 2016-08-05 11:21:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 11:21:26]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/6404)

[jochen (gone - plz use gerrit), 2016-08-05 11:24:40]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 11:24:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 11:48:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 11:48:58]

Dry run: This issue passed the CQ dry run.

[marja, 2016-08-05 11:59:24]

lgtm

[jochen (gone - plz use gerrit), 2016-08-05 11:59:37]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-08-05 11:59:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 12:01:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-05 12:03:19]

Description was changed from

==========
Hook up compiler dispatcher jobs to lazy parser.

The lazy parser actually parses eagerly. It's called lazy because it
parses functions that were previously lazy parsed. D'uh.

BUG=v8:5215
R=marja@chromium.org
==========

to

==========
Hook up compiler dispatcher jobs to lazy parser.

The lazy parser actually parses eagerly. It's called lazy because it
parses functions that were previously lazy parsed. D'uh.

BUG=v8:5215
R=marja@chromium.org

Committed: https://crrev.com/255cc15f98507e2bba49574f4dc38c74deb0ca2c
Cr-Commit-Position: refs/heads/master@{#38375}
==========

[commit-bot: I haz the power, 2016-08-05 12:03:20]

Patchset 3 (id:??) landed as
https://crrev.com/255cc15f98507e2bba49574f4dc38c74deb0ca2c
Cr-Commit-Position: refs/heads/master@{#38375}

[Michael Achenbach, 2016-08-05 12:33:35]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2211393003/ by machenbach@chromium.org.

The reason for reverting is: Need to revert
https://codereview.chromium.org/2216563003 - just reland rebased version.