Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Issue 2216563003: Remove redundant ParseInfo::scope_. (Closed)

Created:
4 years, 4 months ago by neis
Modified:
4 years, 4 months ago
Reviewers:
adamk, marja
CC:
v8-reviews_googlegroups.com, marja
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove redundant ParseInfo::scope_. This was always set to the literal's scope. (Additional change: mark getters as const.) R=adamk@chromium.org BUG= Committed: https://crrev.com/23ea0782977ed3a4dd113462af9ecbfd6ff0ce94 Cr-Commit-Position: refs/heads/master@{#38372}

Patch Set 1 #

Patch Set 2 : Update a comment. #

Patch Set 3 : Mark some getters as const. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -28 lines) Patch
M src/ast/scopes.cc View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/parsing/parser.h View 1 2 3 7 chunks +25 lines, -23 lines 0 comments Download
M src/parsing/parser.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
neis
4 years, 4 months ago (2016-08-04 12:52:58 UTC) #1
adamk
lgtm, but +marja with whom I just this morning had a discussion about FunctionLiteral::scope_. I ...
4 years, 4 months ago (2016-08-04 17:39:32 UTC) #4
adamk
Marja ended up not making the proposed change, so I think this is good to ...
4 years, 4 months ago (2016-08-04 21:23:04 UTC) #6
marja
Yep, lgtm, as I didn't end up putting null Scopes to FunctionLiteral.
4 years, 4 months ago (2016-08-05 07:03:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216563003/60001
4 years, 4 months ago (2016-08-05 10:56:25 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-05 11:17:15 UTC) #13
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/23ea0782977ed3a4dd113462af9ecbfd6ff0ce94 Cr-Commit-Position: refs/heads/master@{#38372}
4 years, 4 months ago (2016-08-05 11:17:58 UTC) #15
Michael Achenbach
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2222503002/ by machenbach@chromium.org. ...
4 years, 4 months ago (2016-08-05 12:20:26 UTC) #16
Michael Achenbach
4 years, 4 months ago (2016-08-05 12:21:14 UTC) #17
Message was sent while issue was closed.
Please just reland a rebased version. Sorry for the inconvenience.

Powered by Google App Engine
This is Rietveld 408576698