Add a button to open TalkBack settings in chrome://settings.

Add a button to open TalkBack settings in chrome://settings.

This change adds a button next to ChromeVox settings button
when ARC is enabled.

BUG=635383
TEST='TalkBack settings' button appears when enabling ChromeVox,
     then TalkBack settings window is opened if clicking the button.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c244a30032cfe4d7066943faf53f21345ea37cdb
Cr-Commit-Position: refs/heads/master@{#410942}

[yhanada, 2016-08-05 07:33:28]

Description was changed from

==========
Add a button to open TalkBack settings in chrome://settings.

This change adds a button next to ChromeVox settings button
when ARC is enabled.

TEST='TalkBack settings' button appears when enabling ChromeVox,
     then TalkBack settings window is opened if clicking the button.
==========

to

==========
Add a button to open TalkBack settings in chrome://settings.

This change adds a button next to ChromeVox settings button
when ARC is enabled.

TEST='TalkBack settings' button appears when enabling ChromeVox,
     then TalkBack settings window is opened if clicking the button.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yhanada, 2016-08-08 04:00:51]

yhanada@chromium.org changed reviewers:
+ stevenjb@chromium.org

[yhanada, 2016-08-08 04:00:52]

Could you review this change? Thanks!

[yhanada, 2016-08-08 04:26:32]

Description was changed from

==========
Add a button to open TalkBack settings in chrome://settings.

This change adds a button next to ChromeVox settings button
when ARC is enabled.

TEST='TalkBack settings' button appears when enabling ChromeVox,
     then TalkBack settings window is opened if clicking the button.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add a button to open TalkBack settings in chrome://settings.

This change adds a button next to ChromeVox settings button
when ARC is enabled.

BUG=635383
TEST='TalkBack settings' button appears when enabling ChromeVox,
     then TalkBack settings window is opened if clicking the button.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-08-08 22:41:01]

stevenjb@chromium.org changed reviewers:
+ dbeam@chromium.org

[stevenjb, 2016-08-08 22:41:05]

+dbeam@ who is working on Accessibility in MD Settings.

https://codereview.chromium.org/2220453002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/2220453002/diff/40001/chrome/browser/resource...
chrome/browser/resources/options/browser_options.js:729: var
updateAccessibilitySettingsButtons = function() {
As long as we are changing the name, maybe make it something
updateAccessibilitySettingsSection? Alternatively just leave the name to reduce
churn in soon-to-be-deprecated code.

https://codereview.chromium.org/2220453002/diff/40001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/arc/arc_app_utils.cc (right):

https://codereview.chromium.org/2220453002/diff/40001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/arc/arc_app_utils.cc:254: return true;
Do we actually use the result anywhere? If not we should make this return void.

https://codereview.chromium.org/2220453002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/2220453002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/browser_options_handler.cc:1948: LOG(ERROR) <<
"Settings can't be invoked for non-primary profile";
Can this legitimately happen? If so it should just be a warning or vlog even. If
not it should be a DCHECK.

[yhanada, 2016-08-09 06:29:41]

https://codereview.chromium.org/2220453002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/2220453002/diff/40001/chrome/browser/resource...
chrome/browser/resources/options/browser_options.js:729: var
updateAccessibilitySettingsButtons = function() {
On 2016/08/08 22:41:03, stevenjb wrote:
> As long as we are changing the name, maybe make it something
> updateAccessibilitySettingsSection? Alternatively just leave the name to
reduce
> churn in soon-to-be-deprecated code.
> 

Done.

https://codereview.chromium.org/2220453002/diff/40001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/arc/arc_app_utils.cc (right):

https://codereview.chromium.org/2220453002/diff/40001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/arc/arc_app_utils.cc:254: return true;
On 2016/08/08 22:41:03, stevenjb wrote:
> Do we actually use the result anywhere? If not we should make this return
void.

Done.

https://codereview.chromium.org/2220453002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/2220453002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/browser_options_handler.cc:1948: LOG(ERROR) <<
"Settings can't be invoked for non-primary profile";
On 2016/08/08 22:41:03, stevenjb wrote:
> Can this legitimately happen? If so it should just be a warning or vlog even.
If
> not it should be a DCHECK.

I changed it to LOG(WARNING). Done.

[stevenjb, 2016-08-09 17:02:52]

lgtm

[yhanada, 2016-08-10 01:43:42]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 01:44:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 02:48:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 02:48:19]

Dry run: This issue passed the CQ dry run.

[yhanada, 2016-08-10 03:18:46]

The CQ bit was checked by yhanada@chromium.org

[commit-bot: I haz the power, 2016-08-10 03:19:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 03:25:22]

Description was changed from

==========
Add a button to open TalkBack settings in chrome://settings.

This change adds a button next to ChromeVox settings button
when ARC is enabled.

BUG=635383
TEST='TalkBack settings' button appears when enabling ChromeVox,
     then TalkBack settings window is opened if clicking the button.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add a button to open TalkBack settings in chrome://settings.

This change adds a button next to ChromeVox settings button
when ARC is enabled.

BUG=635383
TEST='TalkBack settings' button appears when enabling ChromeVox,
     then TalkBack settings window is opened if clicking the button.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-10 03:25:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-10 03:27:54]

Description was changed from

==========
Add a button to open TalkBack settings in chrome://settings.

This change adds a button next to ChromeVox settings button
when ARC is enabled.

BUG=635383
TEST='TalkBack settings' button appears when enabling ChromeVox,
     then TalkBack settings window is opened if clicking the button.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add a button to open TalkBack settings in chrome://settings.

This change adds a button next to ChromeVox settings button
when ARC is enabled.

BUG=635383
TEST='TalkBack settings' button appears when enabling ChromeVox,
     then TalkBack settings window is opened if clicking the button.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c244a30032cfe4d7066943faf53f21345ea37cdb
Cr-Commit-Position: refs/heads/master@{#410942}
==========

[commit-bot: I haz the power, 2016-08-10 03:27:55]

Patchset 4 (id:??) landed as
https://crrev.com/c244a30032cfe4d7066943faf53f21345ea37cdb
Cr-Commit-Position: refs/heads/master@{#410942}