Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2220453002: Add a button to open TalkBack settings in chrome://settings. (Closed)

Created:
4 years, 4 months ago by yhanada
Modified:
4 years, 4 months ago
Reviewers:
stevenjb, Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, elijahtaylor+arcwatch_chromium.org, michaelpg+watch-options_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, arv+watch_chromium.org, Matt Giuca
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a button to open TalkBack settings in chrome://settings. This change adds a button next to ChromeVox settings button when ARC is enabled. BUG=635383 TEST='TalkBack settings' button appears when enabling ChromeVox, then TalkBack settings window is opened if clicking the button. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c244a30032cfe4d7066943faf53f21345ea37cdb Cr-Commit-Position: refs/heads/master@{#410942}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Update comments #

Total comments: 6

Patch Set 4 : Update after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -8 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 2 3 3 chunks +17 lines, -7 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_utils.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_utils.cc View 1 2 3 2 chunks +26 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 3 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
yhanada
Could you review this change? Thanks!
4 years, 4 months ago (2016-08-08 04:00:52 UTC) #3
stevenjb
+dbeam@ who is working on Accessibility in MD Settings. https://codereview.chromium.org/2220453002/diff/40001/chrome/browser/resources/options/browser_options.js File chrome/browser/resources/options/browser_options.js (right): https://codereview.chromium.org/2220453002/diff/40001/chrome/browser/resources/options/browser_options.js#newcode729 chrome/browser/resources/options/browser_options.js:729: ...
4 years, 4 months ago (2016-08-08 22:41:05 UTC) #6
yhanada
https://codereview.chromium.org/2220453002/diff/40001/chrome/browser/resources/options/browser_options.js File chrome/browser/resources/options/browser_options.js (right): https://codereview.chromium.org/2220453002/diff/40001/chrome/browser/resources/options/browser_options.js#newcode729 chrome/browser/resources/options/browser_options.js:729: var updateAccessibilitySettingsButtons = function() { On 2016/08/08 22:41:03, stevenjb ...
4 years, 4 months ago (2016-08-09 06:29:41 UTC) #7
stevenjb
lgtm
4 years, 4 months ago (2016-08-09 17:02:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220453002/60001
4 years, 4 months ago (2016-08-10 03:19:16 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-10 03:25:26 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 03:27:55 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c244a30032cfe4d7066943faf53f21345ea37cdb
Cr-Commit-Position: refs/heads/master@{#410942}

Powered by Google App Engine
This is Rietveld 408576698