Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 2220453002: Add a button to open TalkBack settings in chrome://settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update after review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/browser_options.js
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index 7d7200c5a87b8d75c45d6de6f31228dd9b27d1e9..87fe67040f2629b0acc37badfc47a6ae3f6313a2 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -726,13 +726,13 @@ cr.define('options', function() {
// Accessibility section (CrOS only).
if (cr.isChromeOS) {
- var updateAccessibilitySettingsButton = function() {
+ var updateAccessibilitySettingsSection = function() {
$('accessibility-settings').hidden =
!($('accessibility-spoken-feedback-check').checked);
};
Preferences.getInstance().addEventListener(
'settings.accessibility',
- updateAccessibilitySettingsButton);
+ updateAccessibilitySettingsSection);
$('accessibility-learn-more').onclick = function(unused_event) {
chrome.send('coreOptionsUserMetricsAction',
['Options_AccessibilityLearnMore']);
@@ -740,9 +740,12 @@ cr.define('options', function() {
$('accessibility-settings-button').onclick = function(unused_event) {
window.open(loadTimeData.getString('accessibilitySettingsURL'));
};
+ $('talkback-settings-button').onclick = function(unused_event) {
+ chrome.send('showAccessibilityTalkBackSettings');
+ };
$('accessibility-spoken-feedback-check').onchange =
- updateAccessibilitySettingsButton;
- updateAccessibilitySettingsButton();
+ updateAccessibilitySettingsSection;
+ updateAccessibilitySettingsSection();
var updateScreenMagnifierCenterFocus = function() {
$('accessibility-screen-magnifier-center-focus-check').disabled =
@@ -834,11 +837,18 @@ cr.define('options', function() {
$('android-apps-settings-label').innerHTML =
loadTimeData.getString('androidAppsSettingsLabel');
Preferences.getInstance().addEventListener('arc.enabled', function(e) {
- var settings = $('android-apps-settings');
// Only change settings visibility on committed settings changes.
- if (!settings || e.value.uncommitted)
+ if (e.value.uncommitted)
return;
- settings.hidden = !e.value.value;
+
+ var isArcEnabled = !e.value.value;
+ var androidAppSettings = $('android-apps-settings');
+ if (androidAppSettings != null)
+ androidAppSettings.hidden = isArcEnabled;
+
+ var talkbackSettingsButton = $('talkback-settings-button');
+ if (talkbackSettingsButton != null)
+ talkbackSettingsButton.hidden = isArcEnabled;
});
$('android-apps-settings-link').addEventListener('click', function(e) {
« no previous file with comments | « chrome/browser/resources/options/browser_options.html ('k') | chrome/browser/ui/app_list/arc/arc_app_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698