Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2220443004: Use std::is_convertible in EnsurePtrConvertibleArgDecl (Closed)

Created:
4 years, 4 months ago by hiroshige
Modified:
4 years, 3 months ago
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use std::is_convertible in EnsurePtrConvertibleArgDecl This is to make EnsurePtrConvertibleArgDecl(T, const T) to fail for https://codereview.chromium.org/2220543002. This CL also adds unit tests for EnsurePtrConvertibleArgDecl. BUG= Committed: https://crrev.com/3c828c63cf4612591d02b61ed8455278542fd6e3 Cr-Commit-Position: refs/heads/master@{#418638}

Patch Set 1 #

Patch Set 2 : Rebase and fix #

Patch Set 3 : Fix #

Patch Set 4 : no ifdef #

Patch Set 5 : [TEST ONLY] #

Patch Set 6 : No ifdef, w/ tests #

Patch Set 7 : w/ ifdef, w/ test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -7 lines) Patch
M third_party/WebKit/Source/wtf/TypeTraits.h View 1 2 4 5 6 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/wtf/TypeTraitsTest.cpp View 1 2 3 4 5 1 chunk +36 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (13 generated)
hiroshige
kouhei@, PTAL, as you left comments about MSVC bug.
4 years, 3 months ago (2016-09-01 10:40:44 UTC) #6
kouhei (in TOK)
lgtm
4 years, 3 months ago (2016-09-08 17:43:40 UTC) #11
hiroshige
yutak@, PTAL as a wtf/ OWNER.
4 years, 3 months ago (2016-09-09 06:39:01 UTC) #13
Yuta Kitamura
lgtm
4 years, 3 months ago (2016-09-14 10:37:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220443004/120001
4 years, 3 months ago (2016-09-14 15:55:04 UTC) #16
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 3 months ago (2016-09-14 19:34:32 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 19:37:07 UTC) #20
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/3c828c63cf4612591d02b61ed8455278542fd6e3
Cr-Commit-Position: refs/heads/master@{#418638}

Powered by Google App Engine
This is Rietveld 408576698