ChromeOS: fix crash in HashWallpaperFilesIdStr.

ChromeOS: fix crash in HashWallpaperFilesIdStr.

This CL postpones SetPolicyControlledWallpaper() until system salt is ready.

BUG=615239
TEST=none

Committed: https://crrev.com/35461b845a3ba44af7c2fc28cb60ffe521eecc96
Cr-Commit-Position: refs/heads/master@{#410909}

[Alexander Alekseev, 2016-08-05 05:23:46]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 05:24:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Alekseev, 2016-08-05 05:27:41]

alemate@chromium.org changed reviewers:
+ bshe@chromium.org, dkrahn@chromium.org

[Alexander Alekseev, 2016-08-05 05:27:42]

https://codereview.chromium.org/1886653002 removed delayed
SetPolicyControlledWallpaper(), but it still can happen before system salt is
resolved. So this Cl brings this logic back.

[Alexander Alekseev, 2016-08-05 05:28:03]

Please review.

[Darren Krahn, 2016-08-05 18:54:57]

chromeos/cryptohome lgtm

https://codereview.chromium.org/2220433002/diff/20001/chromeos/cryptohome/sys...
File chromeos/cryptohome/system_salt_getter.cc (right):

https://codereview.chromium.org/2220433002/diff/20001/chromeos/cryptohome/sys...
chromeos/cryptohome/system_salt_getter.cc:46:
on_system_salt_ready_.push_back(closure);
Should the closure be called if salt is already available?

[Alexander Alekseev, 2016-08-06 05:00:12]

https://codereview.chromium.org/2220433002/diff/20001/chromeos/cryptohome/sys...
File chromeos/cryptohome/system_salt_getter.cc (right):

https://codereview.chromium.org/2220433002/diff/20001/chromeos/cryptohome/sys...
chromeos/cryptohome/system_salt_getter.cc:46:
on_system_salt_ready_.push_back(closure);
On 2016/08/05 18:54:56, Darren Krahn wrote:
> Should the closure be called if salt is already available?

Done.

[Alexander Alekseev, 2016-08-09 23:43:48]

alemate@chromium.org changed reviewers:
+ xdai@chromium.org

[Alexander Alekseev, 2016-08-09 23:43:48]

+xdai
Please review.

[xdai1, 2016-08-10 00:02:11]

The code lgtm

Did you manage to repro the crash? Or this CL is just a speculation based on the
crash stack?

[Alexander Alekseev, 2016-08-10 00:26:53]

On 2016/08/10 00:02:11, xdai1 wrote:
> The code lgtm
> 
> Did you manage to repro the crash? Or this CL is just a speculation based on
the
> crash stack?

No, but I am bringing back the flow I removed.

Thank you!

[Alexander Alekseev, 2016-08-10 00:27:00]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2016-08-10 00:27:00]

The patchset sent to the CQ was uploaded after l-g-t-m from dkrahn@chromium.org
Link to the patchset: https://codereview.chromium.org/2220433002/#ps40001
(title: "AddOnSystemSaltReady() should immediately run callback if system salt
is ready.")

[commit-bot: I haz the power, 2016-08-10 00:28:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 01:08:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-10 01:10:55]

Description was changed from

==========
ChromeOS: fix crash in HashWallpaperFilesIdStr.


This CL postpones SetPolicyControlledWallpaper() until system salt is ready.

BUG=615239
TEST=none
==========

to

==========
ChromeOS: fix crash in HashWallpaperFilesIdStr.

This CL postpones SetPolicyControlledWallpaper() until system salt is ready.

BUG=615239
TEST=none

Committed: https://crrev.com/35461b845a3ba44af7c2fc28cb60ffe521eecc96
Cr-Commit-Position: refs/heads/master@{#410909}
==========

[commit-bot: I haz the power, 2016-08-10 01:10:56]

Patchset 3 (id:??) landed as
https://crrev.com/35461b845a3ba44af7c2fc28cb60ffe521eecc96
Cr-Commit-Position: refs/heads/master@{#410909}