Remove WallpaperManager dependency on Cryptohome.

Remove WallpaperManager dependency on Cryptohome.

This Cl adds wallpaper file names hashing to WallpaperManager itself,
removing dependency on cryptohome. No more asynchronous calls.

BUG=462823
TEST=manual

Committed: https://crrev.com/81e10078a524522e862dd33ebdceaf64f4ebeba1
Cr-Commit-Position: refs/heads/master@{#387235}

Committed: https://crrev.com/9558da44f7e531d60fe4e941249bd8c543ce0de4
Cr-Commit-Position: refs/heads/master@{#387514}

[Alexander Alekseev, 2016-04-13 05:20:17]

alemate@chromium.org changed reviewers:
+ bshe@chromium.org, dkrahn@chromium.org

[Alexander Alekseev, 2016-04-13 05:20:18]

Please review:

dkrahn@:
  chromeos/cryptohome/*
  HashWallpaperFilesIdStr() in c/b/c/login/users/wallpaper/wallpaper_manager.cc

bshe@:
  all

[Alexander Alekseev, 2016-04-13 05:27:19]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 05:27:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1886653002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1886653002/80001

[commit-bot: I haz the power, 2016-04-13 06:42:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 06:42:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexander Alekseev, 2016-04-13 09:05:43]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 09:05:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1886653002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1886653002/100001

[commit-bot: I haz the power, 2016-04-13 09:34:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 09:34:50]

Dry run: This issue passed the CQ dry run.

[Darren Krahn, 2016-04-13 16:33:44]

chromeos/cryptohome lgtm

https://codereview.chromium.org/1886653002/diff/100001/chromeos/cryptohome/sy...
File chromeos/cryptohome/system_salt_getter.cc (right):

https://codereview.chromium.org/1886653002/diff/100001/chromeos/cryptohome/sy...
chromeos/cryptohome/system_salt_getter.cc:46: if (!raw_salt_.empty())
optional: candidate for a ternary operator?

 return raw_salt_.empty() ? nullptr : &raw_salt_;

https://codereview.chromium.org/1886653002/diff/100001/chromeos/cryptohome/sy...
File chromeos/cryptohome/system_salt_getter.h (right):

https://codereview.chromium.org/1886653002/diff/100001/chromeos/cryptohome/sy...
chromeos/cryptohome/system_salt_getter.h:44: const SystemSaltGetter::RawSalt*
GetRawSalt() const;
nit: SystemSaltGetter:: not necessary

https://codereview.chromium.org/1886653002/diff/100001/chromeos/cryptohome/sy...
chromeos/cryptohome/system_salt_getter.h:47: void SetRawSaltForTesting(const
SystemSaltGetter::RawSalt& raw_salt);
nit: Here too

[bshe, 2016-04-13 20:00:19]

lgtm with nits

https://codereview.chromium.org/1886653002/diff/100001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc (right):

https://codereview.chromium.org/1886653002/diff/100001/chrome/browser/chromeo...
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc:134: //
wallpaper identification purpose only.
nit: perhaps also document why do we want to copy the logic here.

https://codereview.chromium.org/1886653002/diff/100001/chrome/browser/chromeo...
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc:1132: const
AccountId& account_id) const {
nit: consider move the implementation of GetWallpaperFilesId to here?

[Alexander Alekseev, 2016-04-14 03:37:29]

https://codereview.chromium.org/1886653002/diff/100001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc (right):

https://codereview.chromium.org/1886653002/diff/100001/chrome/browser/chromeo...
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc:134: //
wallpaper identification purpose only.
On 2016/04/13 20:00:19, bshe wrote:
> nit: perhaps also document why do we want to copy the logic here.

Done.

https://codereview.chromium.org/1886653002/diff/100001/chrome/browser/chromeo...
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc:1132: const
AccountId& account_id) const {
On 2016/04/13 20:00:19, bshe wrote:
> nit: consider move the implementation of GetWallpaperFilesId to here?

Done.

https://codereview.chromium.org/1886653002/diff/100001/chromeos/cryptohome/sy...
File chromeos/cryptohome/system_salt_getter.cc (right):

https://codereview.chromium.org/1886653002/diff/100001/chromeos/cryptohome/sy...
chromeos/cryptohome/system_salt_getter.cc:46: if (!raw_salt_.empty())
On 2016/04/13 16:33:43, Darren Krahn wrote:
> optional: candidate for a ternary operator?
> 
>  return raw_salt_.empty() ? nullptr : &raw_salt_;

Done.

https://codereview.chromium.org/1886653002/diff/100001/chromeos/cryptohome/sy...
File chromeos/cryptohome/system_salt_getter.h (right):

https://codereview.chromium.org/1886653002/diff/100001/chromeos/cryptohome/sy...
chromeos/cryptohome/system_salt_getter.h:44: const SystemSaltGetter::RawSalt*
GetRawSalt() const;
On 2016/04/13 16:33:44, Darren Krahn wrote:
> nit: SystemSaltGetter:: not necessary

Done.

https://codereview.chromium.org/1886653002/diff/100001/chromeos/cryptohome/sy...
chromeos/cryptohome/system_salt_getter.h:47: void SetRawSaltForTesting(const
SystemSaltGetter::RawSalt& raw_salt);
On 2016/04/13 16:33:43, Darren Krahn wrote:
> nit: Here too

Done.

[Alexander Alekseev, 2016-04-14 03:38:21]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2016-04-14 03:38:22]

The patchset sent to the CQ was uploaded after l-g-t-m from dkrahn@chromium.org,
bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/1886653002/#ps120001
(title: "Update after review.")

[commit-bot: I haz the power, 2016-04-14 03:38:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1886653002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1886653002/120001

[commit-bot: I haz the power, 2016-04-14 04:25:36]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-04-14 04:26:53]

Description was changed from

==========
Remove WallpaperManager dependency on Cryptohome.

This Cl adds wallpaper file names hashing to WallpaperManager itself,
removing dependency on cryptohome. No more asynchronous calls.

BUG=462823
TEST=manual
==========

to

==========
Remove WallpaperManager dependency on Cryptohome.

This Cl adds wallpaper file names hashing to WallpaperManager itself,
removing dependency on cryptohome. No more asynchronous calls.

BUG=462823
TEST=manual

Committed: https://crrev.com/81e10078a524522e862dd33ebdceaf64f4ebeba1
Cr-Commit-Position: refs/heads/master@{#387235}
==========

[commit-bot: I haz the power, 2016-04-14 04:26:55]

Patchset 7 (id:??) landed as
https://crrev.com/81e10078a524522e862dd33ebdceaf64f4ebeba1
Cr-Commit-Position: refs/heads/master@{#387235}

[ilja, 2016-04-14 21:15:40]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1887983005/ by ihf@chromium.org.

The reason for reverting is: crbug.com/603655.

[Alexander Alekseev, 2016-04-15 00:48:10]

Description was changed from

==========
Remove WallpaperManager dependency on Cryptohome.

This Cl adds wallpaper file names hashing to WallpaperManager itself,
removing dependency on cryptohome. No more asynchronous calls.

BUG=462823
TEST=manual

Committed: https://crrev.com/81e10078a524522e862dd33ebdceaf64f4ebeba1
Cr-Commit-Position: refs/heads/master@{#387235}
==========

to

==========
Remove WallpaperManager dependency on Cryptohome.

This Cl adds wallpaper file names hashing to WallpaperManager itself,
removing dependency on cryptohome. No more asynchronous calls.

BUG=462823
TEST=manual

Committed: https://crrev.com/81e10078a524522e862dd33ebdceaf64f4ebeba1
Cr-Commit-Position: refs/heads/master@{#387235}
==========

[Alexander Alekseev, 2016-04-15 00:48:17]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-15 00:48:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1886653002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1886653002/140001

[commit-bot: I haz the power, 2016-04-15 01:27:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 01:27:08]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2016-04-15 01:36:31]

Relanding with simple fix.

[Alexander Alekseev, 2016-04-15 01:36:52]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2016-04-15 01:36:53]

The patchset sent to the CQ was uploaded after l-g-t-m from dkrahn@chromium.org,
bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/1886653002/#ps140001
(title: "Fix rebase (raw_salt_ is now properly set).")

[commit-bot: I haz the power, 2016-04-15 01:37:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1886653002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1886653002/140001

[commit-bot: I haz the power, 2016-04-15 01:41:56]

Description was changed from

==========
Remove WallpaperManager dependency on Cryptohome.

This Cl adds wallpaper file names hashing to WallpaperManager itself,
removing dependency on cryptohome. No more asynchronous calls.

BUG=462823
TEST=manual

Committed: https://crrev.com/81e10078a524522e862dd33ebdceaf64f4ebeba1
Cr-Commit-Position: refs/heads/master@{#387235}
==========

to

==========
Remove WallpaperManager dependency on Cryptohome.

This Cl adds wallpaper file names hashing to WallpaperManager itself,
removing dependency on cryptohome. No more asynchronous calls.

BUG=462823
TEST=manual

Committed: https://crrev.com/81e10078a524522e862dd33ebdceaf64f4ebeba1
Cr-Commit-Position: refs/heads/master@{#387235}
==========

[commit-bot: I haz the power, 2016-04-15 01:41:58]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-04-15 01:43:32]

Description was changed from

==========
Remove WallpaperManager dependency on Cryptohome.

This Cl adds wallpaper file names hashing to WallpaperManager itself,
removing dependency on cryptohome. No more asynchronous calls.

BUG=462823
TEST=manual

Committed: https://crrev.com/81e10078a524522e862dd33ebdceaf64f4ebeba1
Cr-Commit-Position: refs/heads/master@{#387235}
==========

to

==========
Remove WallpaperManager dependency on Cryptohome.

This Cl adds wallpaper file names hashing to WallpaperManager itself,
removing dependency on cryptohome. No more asynchronous calls.

BUG=462823
TEST=manual

Committed: https://crrev.com/81e10078a524522e862dd33ebdceaf64f4ebeba1
Cr-Commit-Position: refs/heads/master@{#387235}

Committed: https://crrev.com/9558da44f7e531d60fe4e941249bd8c543ce0de4
Cr-Commit-Position: refs/heads/master@{#387514}
==========

[commit-bot: I haz the power, 2016-04-15 01:43:34]

Patchset 8 (id:??) landed as
https://crrev.com/9558da44f7e531d60fe4e941249bd8c543ce0de4
Cr-Commit-Position: refs/heads/master@{#387514}