[Typed-OM] Add Image typedom_types to properties and enable them to be set with StyleMap

third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
index 9c621901859d2b610cc0b928e9a1a4e6d459a95e..90b3b30ae0dc82645ade92de2259583e6d8fb515 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
@@ -682,6 +682,11 @@ void StyleBuilderFunctions::applyValueCSSPropertyContent(StyleResolverState& sta
         return;
     }
 
+    if (value.isImageValue()) {
+        state.style()->setContent(ContentData::create(state.styleImage(CSSPropertyContent, value)));
+        return;
+    }

[meade_UTC10, 2016/08/10 07:16:05]

What's this for?

[anthonyhkf, 2016/08/10 07:26:09]

I cannot use "styleMap.set('content', ...)" if it isn't there. It will have
runtime error when the toCSSValueList(value) is called because the 'value' is
not a CSSValueList. And when I checked the class type of the 'value' variable,
it was ImageClass, so I added those lines.

[Timothy Loh, 2016/08/10 07:44:05]

Aside from the values 'none' and 'normal', content takes a list of values. So
for now we can probably add supports_multiple in CSSProperties.in instead of
having this code here.

[meade_UTC10, 2016/08/11 00:44:41]

Also, if a reviewer asks you to do something and you find out that it'll take
extra code somewhere else, it's better to say to the reviewer "that requires
extra changes that are unrelated to this CL, I'll do it in another CL", then
have this discussion on the new CL. This avoids polluting the history of a
simple CL with discussion about some random thing. The golden rule is "keep CLs
small and focused".

In this case, you were originally just adding things to CSSProperties.in and
adding tests for them. Let's stick to just that.

+
     ContentData* firstContent = nullptr;
     ContentData* prevContent = nullptr;
     for (auto& item : toCSSValueList(value)) {