[Typed-OM] Add Image typedom_types to properties and enable them to be set with StyleMap

third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
@@ skipping 664 matching lines @@
 }
 
 void StyleBuilderFunctions::applyValueCSSPropertyContent(StyleResolverState& state, const CSSValue& value)
 {
     if (value.isPrimitiveValue()) {
         DCHECK(toCSSPrimitiveValue(value).getValueID() == CSSValueNormal || toCSSPrimitiveValue(value).getValueID() == CSSValueNone);
         state.style()->setContent(nullptr);
         return;
     }
 
+    if (value.isImageValue()) {
+        state.style()->setContent(ContentData::create(state.styleImage(CSSPropertyContent, value)));
+        return;
+    }

[meade_UTC10, 2016/08/10 07:16:05]

What's this for?

[anthonyhkf, 2016/08/10 07:26:09]

I cannot use "styleMap.set('content', ...)" if it isn't there. It will have
runtime error when the toCSSValueList(value) is called because the 'value' is
not a CSSValueList. And when I checked the class type of the 'value' variable,
it was ImageClass, so I added those lines.

[Timothy Loh, 2016/08/10 07:44:05]

Aside from the values 'none' and 'normal', content takes a list of values. So
for now we can probably add supports_multiple in CSSProperties.in instead of
having this code here.

[meade_UTC10, 2016/08/11 00:44:41]

Also, if a reviewer asks you to do something and you find out that it'll take
extra code somewhere else, it's better to say to the reviewer "that requires
extra changes that are unrelated to this CL, I'll do it in another CL", then
have this discussion on the new CL. This avoids polluting the history of a
simple CL with discussion about some random thing. The golden rule is "keep CLs
small and focused".

In this case, you were originally just adding things to CSSProperties.in and
adding tests for them. Let's stick to just that.

+
     ContentData* firstContent = nullptr;
     ContentData* prevContent = nullptr;
     for (auto& item : toCSSValueList(value)) {
         ContentData* nextContent = nullptr;
         if (item->isImageGeneratorValue() || item->isImageSetValue() || item->isImageValue()) {
             nextContent = ContentData::create(state.styleImage(CSSPropertyContent, *item));
         } else if (item->isCounterValue()) {
             const CSSCounterValue* counterValue = toCSSCounterValue(item.get());
             EListStyleType listStyleType = NoneListStyle;
             CSSValueID listStyleIdent = counterValue->listStyle();
@@ skipping 163 matching lines @@
     }
 }
 
 void StyleBuilderFunctions::applyInheritCSSPropertyPosition(StyleResolverState& state)
 {
     if (!state.parentNode()->isDocumentNode())
         state.style()->setPosition(state.parentStyle()->position());
 }
 
 } // namespace blink